Currently, Telit plugin depends on ID_MM_TELIT_PORTS_TAGGED environment variable, set by udev, for tagging modems that support dynamic port config (#PORTCFG)
To remove this dependency from udev, Telit plugin now relies only on the error management of the command AT#PORTCFG? itself in order to see whether the modem supports it or not. --- Sending again this part of the patch even without modification, so it should be easier to apply both parts. --- plugins/telit/77-mm-telit-port-types.rules | 9 --------- plugins/telit/mm-common-telit.c | 10 ++-------- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/plugins/telit/77-mm-telit-port-types.rules b/plugins/telit/77-mm-telit-port-types.rules index 01538cb..b052962 100644 --- a/plugins/telit/77-mm-telit-port-types.rules +++ b/plugins/telit/77-mm-telit-port-types.rules @@ -33,13 +33,4 @@ ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1010", ENV{.MM_USBIFNUM}=="03", ENV{ # CE910-DUAL ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1011", ENV{.MM_USBIFNUM}=="01", ENV{ID_MM_TELIT_PORT_TYPE_MODEM}="1" -# HE910, UE910, UL865 (dynamic port identification supported) -ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="0021", ENV{ID_MM_TELIT_PORTS_TAGGED}="1" - -# GE910 (dynamic port identification supported) -ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="0022", ENV{ID_MM_TELIT_PORTS_TAGGED}="1" - -# LE910 V2 -ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="0036", ENV{ID_MM_TELIT_PORTS_TAGGED}="1" - LABEL="mm_telit_port_types_end" diff --git a/plugins/telit/mm-common-telit.c b/plugins/telit/mm-common-telit.c index 622f63d..8b470f4 100644 --- a/plugins/telit/mm-common-telit.c +++ b/plugins/telit/mm-common-telit.c @@ -336,12 +336,6 @@ telit_custom_init (MMPortProbe *probe, ctx->getportcfg_done = FALSE; ctx->getportcfg_retries = 3; - /* If the device is tagged for supporting #PORTCFG do the custom init */ - if (mm_kernel_device_get_global_property_as_boolean (port_device, "ID_MM_TELIT_PORTS_TAGGED")) { - telit_custom_init_step (ctx); - return; - } - - g_simple_async_result_set_op_res_gboolean (ctx->result, TRUE); - telit_custom_init_context_complete_and_free (ctx); + telit_custom_init_step (ctx); + return; } -- 2.9.3 _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel