On Mon, Jun 5, 2017 at 1:56 PM, Aleksander Morgado
<aleksan...@aleksander.es> wrote:
> On Mon, Jun 5, 2017 at 9:51 AM, Carlo Lobrano <c.lobr...@gmail.com> wrote:
>> I tested this patch and it looks good to me (I specially like the second
>> one). There is just a little mistake I made in my part of the patch. In the
>> "status changed" log I inverted current status with the previous one.
>>
>> ---
>> plugins/telit/mm-broadband-modem-telit.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/plugins/telit/mm-broadband-modem-telit.c
>> b/plugins/telit/mm-broadband-modem-telit.c
>> index 7c93c0d..e78a195 100644
>> --- a/plugins/telit/mm-broadband-modem-telit.c
>> +++ b/plugins/telit/mm-broadband-modem-telit.c
>> @@ -125,9 +125,9 @@ telit_qss_unsolicited_handler (MMPortSerialAt *port,
>> self->priv->qss_status = cur_qss_status;
>>
>> if (cur_qss_status != prev_qss_status)
>> - mm_dbg ("QSS: status changed '%s -> %s",
>> - mm_telit_qss_status_get_string (cur_qss_status),
>> - mm_telit_qss_status_get_string (prev_qss_status));
>> + mm_dbg ("QSS: status changed %s -> %s",
>> + mm_telit_qss_status_get_string (prev_qss_status),
>> + mm_telit_qss_status_get_string (cur_qss_status));
>>
>> if ((prev_qss_status == QSS_STATUS_SIM_REMOVED && cur_qss_status !=
>> QSS_STATUS_SIM_REMOVED) ||
>> (prev_qss_status > QSS_STATUS_SIM_REMOVED && cur_qss_status ==
>> QSS_STATUS_SIM_REMOVED)) {
>> --
>>
>>
>> Can I submit a little patch just for that or do you prefer doing otherwise?
>
> I'll fix it up before merging, no worries.
>
I merged the patches to git master now; plus some addiitonal distcheck
fixes regarding to the new telit enum types files generated.
Cheers!
--
Aleksander
https://aleksander.es
_______________________________________________
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
