On Fri, Jul 14, 2017 at 9:51 AM, Aleksander Morgado <[email protected]> wrote: >>> Currently, when SIM hot swap fails in either mm-iface or plugin, the >>> ModemManager still opens ports context and prints a message saying that >>> SIM hot swap is supported and that it's waiting for SIM insertion, >>> instead of clearly saying that SIM hot swap is not working. >>> >>> This patch: >>> >>> 1. introduces a new property MM_IFACE_MODEM_SIM_HOT_SWAP_CONFIGURED >>> which is FALSE by default and set to TRUE only when >>> setup_sim_hot_swap_finish() succeded. >>> 2. subordinates the completion of SIM hot swap setup (in >>> mm-broadband-modem) and the related messages to the the value of >>> MM_IFACE_MODEM_SIM_HOT_SWAP_CONFIGURED >> >> It looks to me that the "sim_hot_swap_on" in mm-broadband-modem-mbim.c >> would serve the same purpose of this new >> MM_IFACE_MODEM_SIM_HOT_SWAP_CONFIGURED property, isn't that right? >> >> i.e. if SIM how swap enabling fails, both those booleans get set to >> FALSE, so that the code afterwards skips steps as sim hot swap isn't >> configured. What do you guys think? Maybe we should also update the >> MBIM implementation to use this new >> MM_IFACE_MODEM_SIM_HOT_SWAP_CONFIGURED property? > > Any chance you can update also the MBIM implementation to use > MM_IFACE_MODEM_SIM_HOT_SWAP_CONFIGURED in the same way?
Well, or Eric, would you also be up to doing that? -- Aleksander https://aleksander.es _______________________________________________ ModemManager-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
