> > This is a great test of the migration instructions in that wiki page. If you > found any discrepancies don't hesitate to edit the page. >
Will do, once discussed (as I'm not sure whether they are my bugs or real discrepancies :)). > I wonder if you have the same patch on a Github branch or Bugzilla or > somewhere else with a code review UI? That would be easier for me to get an > overview of the changes and make comments inline. > In github here: https://github.com/aleksander0m/ModemManager/commit/79ae18fd22cb56c2d9c78b9bbe39b19de4b9d90d > I do think you should go ahead and require itstool at build time. > This would greatly simplify the logic I believe. > Additionally, you could check if you can assume a recent enough version of > gettext that you could do without itstool and just use Gettext's built-in > support for ITS rules: > https://www.gnu.org/software/gettext/manual/html_node/Preparing-ITS-Rules.html#Preparing-ITS-Rules > Oh, that would be even better. The patch requests gettext 0.19.7, which should already support custom ITS rules; I'll sync with Daiki. -- Aleksander https://aleksander.es _______________________________________________ ModemManager-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
