On Thu, 2017-09-14 at 22:00 -0700, Aleksander Morgado wrote: > Hey, > > This updated patch series to support the TOBY-L4 also includes > support for modifying currently selected bands with AT+UACT, instead > of AT+UBANDSEL, as the latter is deprecated. Additionally, > AT+UAUTHREQ=? output is parsed to see which auth methods we can use > before assuming they are supported. > > Comments?
Nope, LGTM. I'm sure there's something I missed, but I couldn't find anything. Dan > [PATCH v2 01/13] ublox: allow creating u-blox bearers if... > [PATCH v2 02/13] ublox: fallback to router mode if networking > mode > [PATCH v2 03/13] ublox: define port type hints for the TOBY-L4 > [PATCH v2 04/13] ublox,tests: define common method to compare > bands > [PATCH v2 05/13] ublox: new AT+UACT? response parser > [PATCH v2 06/13] ublox: new AT+UACT=? test parser > [PATCH v2 07/13] ublox: new AT+UACT=X command builder > [PATCH v2 08/13] ublox: try to use AT+UACT=? to query supported > bands > [PATCH v2 09/13] ublox: try to use AT+UACT? to query current > bands > [PATCH v2 10/13] ublox: try to use AT+UACT=X to set current bands > [PATCH v2 11/13] ublox: if authentication not required, ignore > [PATCH v2 12/13] ublox: new +UAUTHREQ=? tester > [PATCH v2 13/13] ublox: check which auth methods are supported > _______________________________________________ > ModemManager-devel mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel _______________________________________________ ModemManager-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
