Ok, here is the MR: 
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/419
[https://gitlab.freedesktop.org/uploads/-/system/project/avatar/184/ModemManager-icon.png]<https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/419>
Resolve "mmcli coredump when device is not correctly initialized" (!419) · 
Merge Requests · Mobile broadband connectivity / 
ModemManager<https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/419>
Closes #289
gitlab.freedesktop.org


For the mmcli commit, I only protect the calls that I felt was the most 
important, but let's discuss that in the MR.
________________________________
From: Aleksander Morgado <aleksan...@aleksander.es>
Sent: Saturday, December 19, 2020 2:33 PM
To: Frederic Martinsons <frederic.martins...@sigfox.com>
Cc: modemmanager-devel@lists.freedesktop.org 
<modemmanager-devel@lists.freedesktop.org>
Subject: Re: Modem SORACOM (SC-QGLC4-C1) : Unable to find a usable modem 
character set

Hey,

> Thanks for the answer Aleksander, by the way, I finally got a nano sim for my 
> model and all went well. But, sadly same errors happens if the sim is locked 
> (same error on CSCS than when the sim was missing).
>
> I'll try at the beginning of next week to implement what you suggest on 
> default encoding (by the way, what would be the best default: GSM, UTF8 ?)
>

I'd say you just keep the encoding as UNKNOWN, and warn instead of
failing in a fatal way.

> Do you prefer that I issue one MR for mmcli protection about peek_modem and 
> one for default charset? Or can I do both on the same MR?
>

As long as you prepare 2 different commits for those 2 things, I don't
mind if they are in one single MR or in 2 MRs :)

Cheers!

--
Aleksander
https://aleksander.es
_______________________________________________
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Reply via email to