Geoffrey Young wrote:


[EMAIL PROTECTED] wrote:

stas 2003/03/31 21:20:51

  Modified:    xs/Apache/Filter Apache__Filter.h
               xs/maps  modperl_functions.map
               xs/tables/current/ModPerl FunctionTable.pm
               todo     filters.txt
               .        Changes
  Added:       t/filter/TestFilter out_str_remove.pm
               t/filter out_str_remove.t
  Log:
  implement $filter->remove (filter self-removal) + tests


the test does not pass for me

filter/out_str_remove....1..1
...
# testing : a filter that removes itself
# expected: 'F_O_O_b_a_r_'
# received: 'F_O_O_'
not ok 1
# Failed test 1 in filter/out_str_remove.t at line 13

truthfully, it looks to me like it's the test data that's wrong - you flush between printing 'Foo' and 'bar', sending the data down the chain. so the uppercase filter is uppercasing 'Foo' in one buffer then removing itself, never seeing 'bar', which is exactly what I would expect.

if the filter is not in the chain the data will just pass through. I'm not quite sure why it doesn't work for you. Can you uncomment the warn statements in both filters and see whether they are called? the second filter: insert_underscores should be always called (2 or 3 times with this data).


What Apache version do you use?

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com



Reply via email to