stas 2003/12/19 18:55:00
Modified: . STATUS Log: Log the patch from "Douglas K. Fischer" <fischerdk () purefm ! net>
Revision Changes Path 1.44 +8 -1 modperl/STATUS
Index: STATUS =================================================================== RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.43 retrieving revision 1.44 diff -u -u -r1.43 -r1.44 --- STATUS 1 Dec 2003 17:54:39 -0000 1.43 +++ STATUS 20 Dec 2003 02:55:00 -0000 1.44 @@ -12,6 +12,13 @@
Available Patches:
+ * Improper signal handler restoration with sigaction()
+ Report: +Patch
+ http://marc.theaimsgroup.com/?l=apache-modperl&m=107177256515969&w=2
+ http://marc.theaimsgroup.com/?l=apache-modperl&m=103374262313616&w=2
+ Status: Rafael Garcia-Suarez says the patch looks good at the
+ first glance
+
This patch works fine for me under 5.6.1, although I'm wondering why the change to mod_perl.h wasn't #ifdef'd like the others, probably better to do this:
--- src/modules/perl/mod_perl.h 7 Apr 2003 23:16:23 -0000 1.118 +++ src/modules/perl/mod_perl.h 26 Dec 2003 11:18:15 -0000 @@ -1056,7 +1056,11 @@ } perl_dir_config;
typedef struct {
+#ifdef HAS_SIGACTION
+ Sigsave_t h;
+#else
Sighandler_t h;
+#endif
I32 signo;
} perl_request_sigsave;Under 5.8.2 the patch fails:
modules/perl/libperl.a(mod_perl.o): In function `per_request_cleanup':
mod_perl.o(.text+0x1f1d): undefined reference to `rsignal_restore'
modules/perl/libperl.a(perl_config.o): In function `perl_create_request_config':
perl_config.o(.text+0x8e8): undefined reference to `rsignal_save'
*** Error code 1
Haven't had the time to dig into this further yet.
-- Eric Cholet
