stas 2004/03/10 14:47:40
Modified: ModPerl-Registry/lib/ModPerl RegistryCooker.pm Log: explain why substr($@, 0, 4) ne " at " doesn't constitute a failure Revision Changes Path 1.44 +5 -1 modperl-2.0/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm Index: RegistryCooker.pm =================================================================== RCS file: /home/cvs/modperl-2.0/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm,v retrieving revision 1.43 retrieving revision 1.44 diff -u -u -r1.43 -r1.44 --- RegistryCooker.pm 9 Mar 2004 06:33:55 -0000 1.43 +++ RegistryCooker.pm 10 Mar 2004 22:47:40 -0000 1.44 @@ -704,7 +704,11 @@ sub error_check { my $self = shift; - if ($@ and substr($@,0,4) ne " at ") { + + # ModPerl::Util::exit() is implemented as croak with no message + # so perl will set $@ to " at /some/path", which is not an error + # (see modperl_perl_exit() and modperl_errsv() C functions) + if ($@ and substr($@, 0, 4) ne " at ") { $self->log_error($@); return Apache::SERVER_ERROR; }