stas 2004/05/25 19:34:45
Modified: t/response/TestAPR pool.pm
todo release
Log:
disable for now the clear tests, as it causes side-effect problems on
windows
Revision Changes Path
1.15 +28 -25 modperl-2.0/t/response/TestAPR/pool.pm
Index: pool.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/response/TestAPR/pool.pm,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -u -r1.14 -r1.15
--- pool.pm 24 May 2004 18:38:39 -0000 1.14
+++ pool.pm 26 May 2004 02:34:45 -0000 1.15
@@ -16,7 +16,7 @@
sub handler {
my $r = shift;
- plan $r, tests => 78;
+ plan $r, tests => 69;
### native pools ###
@@ -390,30 +390,33 @@
"non existing function");
}
- ### $p->clear ###
- {
- my ($pp, $sp) = both_pools_create_ok($r);
- $pp->clear;
- # both pools should have run their cleanups
- both_pools_destroy_ok($r);
-
- # sub-pool $sp should be now bogus, as clear() destroys
- # subpools
- eval { $sp->parent_get };
- ok t_cmp(qr/invalid pool object/,
- $@,
- "clear destroys sub pools");
-
- # now we should be able to use the parent pool without
- # allocating it
- $pp->cleanup_register(\&set_cleanup, [$r, 're-using pool']);
- $pp->destroy;
-
- my @notes = $r->notes->get('cleanup');
- ok t_cmp('re-using pool', $notes[0]);
-
- $r->notes->clear;
- }
+# XXX: on windows $pool->clean, followed by $pool->destroy breaks
+# other tests. on unix it works fine.
+#
+# ### $p->clear ###
+# {
+# my ($pp, $sp) = both_pools_create_ok($r);
+# $pp->clear;
+# # both pools should have run their cleanups
+# both_pools_destroy_ok($r);
+#
+# # sub-pool $sp should be now bogus, as clear() destroys
+# # subpools
+# eval { $sp->parent_get };
+# ok t_cmp(qr/invalid pool object/,
+# $@,
+# "clear destroys sub pools");
+#
+# # now we should be able to use the parent pool without
+# # allocating it
+# $pp->cleanup_register(\&set_cleanup, [$r, 're-using pool']);
+# $pp->destroy;
+#
+# my @notes = $r->notes->get('cleanup');
+# ok t_cmp('re-using pool', $notes[0]);
+#
+# $r->notes->clear;
+# }
# a pool can be tagged, so when doing low level apr_pool tracing
1.27 +5 -0 modperl-2.0/todo/release
Index: release
===================================================================
RCS file: /home/cvs/modperl-2.0/todo/release,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -u -r1.26 -r1.27
--- release 21 May 2004 18:34:04 -0000 1.26
+++ release 26 May 2004 02:34:45 -0000 1.27
@@ -4,6 +4,10 @@
-- see also todo/api_status
+* on windows $pool->clean, followed by $pool->destroy breaks other tests
+ See test TestAPR::pool
+ http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=108547894817083&w=2
+
* consider changing the allocation method in APR::Bucket::new from
malloc/free to bucket_alloc, like all other buckets do
@@ -120,3 +124,4 @@
* Apache->unescape_url{_info}:
not yet implemented. should be moved to Apache::Util
+
