stas 2004/10/18 16:19:52
Modified: src/modules/perl modperl_handler.c
Log:
dTHX is never a good idea unless you can't avoid it!
Revision Changes Path
1.29 +7 -7 modperl-2.0/src/modules/perl/modperl_handler.c
Index: modperl_handler.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_handler.c,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -u -r1.28 -r1.29
--- modperl_handler.c 15 Aug 2004 20:06:51 -0000 1.28
+++ modperl_handler.c 18 Oct 2004 23:19:52 -0000 1.29
@@ -245,15 +245,15 @@
va_end(args);
}
-#define set_desc(dtype) \
+#define set_desc(dtype) \
if (desc) *desc = modperl_handler_desc_##dtype(idx)
-#define check_modify(dtype) \
-if ((action > MP_HANDLER_ACTION_GET) && rcfg) { \
- dTHX; \
- Perl_croak(aTHX_ "too late to modify %s handlers", \
- modperl_handler_desc_##dtype(idx)); \
-}
+#define check_modify(dtype) \
+ if ((action > MP_HANDLER_ACTION_GET) && rcfg) { \
+ MP_dSCFG_dTHX; \
+ Perl_croak(aTHX_ "too late to modify %s handlers", \
+ modperl_handler_desc_##dtype(idx)); \
+ }
/*
* generic function to lookup handlers for use in modperl_callback(),
