svn commit: r807116 - in /perl/modperl/trunk: Changes lib/Apache2/Build.pm lib/ModPerl/BuildMM.pm lib/ModPerl/MM.pm

[torsten]

Author: torsten
Date: Mon Aug 24 08:29:43 2009
New Revision: 807116

URL: http://svn.apache.org/viewvc?rev=807116&view=rev
Log:
Fix a typo in ModPerl::BuildMM. Fix a compile time issue by introducing
lexically scoped loop variables in ModPerl::MM::WriteMakefile().

Modified:
    perl/modperl/trunk/Changes
    perl/modperl/trunk/lib/Apache2/Build.pm
    perl/modperl/trunk/lib/ModPerl/BuildMM.pm
    perl/modperl/trunk/lib/ModPerl/MM.pm

Modified: perl/modperl/trunk/Changes
URL: 
http://svn.apache.org/viewvc/perl/modperl/trunk/Changes?rev=807116&r1=807115&r2=807116&view=diff
==============================================================================
--- perl/modperl/trunk/Changes (original)
+++ perl/modperl/trunk/Changes Mon Aug 24 08:29:43 2009
@@ -12,6 +12,9 @@
 
 =item 2.0.5-dev
 
+Fix a typo in ModPerl::BuildMM and introduce lexically scoped loop
+variables in ModPerl::MM::WriteMakefile(). [Torsten Foertsch]
+
 Fix an XSS issue in Apache2::Status reported by Richard J. Brain
 <rich...@procheckup.com>. [Torsten Foertsch]
 

Modified: perl/modperl/trunk/lib/Apache2/Build.pm
URL: 
http://svn.apache.org/viewvc/perl/modperl/trunk/lib/Apache2/Build.pm?rev=807116&r1=807115&r2=807116&view=diff
==============================================================================
--- perl/modperl/trunk/lib/Apache2/Build.pm (original)
+++ perl/modperl/trunk/lib/Apache2/Build.pm Mon Aug 24 08:29:43 2009
@@ -2068,6 +2068,7 @@
 }
 
 sub inc {
+    local $_;
     my @includes = map { "-I$_" } @{ shift->includes };
     "@includes";
 }

Modified: perl/modperl/trunk/lib/ModPerl/BuildMM.pm
URL: 
http://svn.apache.org/viewvc/perl/modperl/trunk/lib/ModPerl/BuildMM.pm?rev=807116&r1=807115&r2=807116&view=diff
==============================================================================
--- perl/modperl/trunk/lib/ModPerl/BuildMM.pm (original)
+++ perl/modperl/trunk/lib/ModPerl/BuildMM.pm Mon Aug 24 08:29:43 2009
@@ -76,9 +76,9 @@
     $build ||= build_config();
     ModPerl::MM::my_import(__PACKAGE__);
 
-    my $inc;
+    my $inc = $args{INC} || '';
     $inc = $args{INC} if $args{INC};
-    $inc = " " . $build->inc;
+    $inc .= " " . $build->inc;
     if (my $glue_inc = $build->{MP_XS_GLUE_DIR}) {
         for (split /\s+/, $glue_inc) {
             $inc .= " -I$_";

Modified: perl/modperl/trunk/lib/ModPerl/MM.pm
URL: 
http://svn.apache.org/viewvc/perl/modperl/trunk/lib/ModPerl/MM.pm?rev=807116&r1=807115&r2=807116&view=diff
==============================================================================
--- perl/modperl/trunk/lib/ModPerl/MM.pm (original)
+++ perl/modperl/trunk/lib/ModPerl/MM.pm Mon Aug 24 08:29:43 2009
@@ -132,22 +132,22 @@
     my_import(__PACKAGE__);
 
     # set top-level WriteMakefile's values if weren't set already
-    for (@default_opts) {
-        $args{$_} = get_def_opt($_) unless exists $args{$_}; # already defined
+    for my $o (@default_opts) {
+        $args{$o} = get_def_opt($o) unless exists $args{$o}; # already defined
     }
 
     # set dynamic_lib-level WriteMakefile's values if weren't set already
     $args{dynamic_lib} ||= {};
     my $dlib = $args{dynamic_lib};
-    for (@default_dlib_opts) {
-        $dlib->{$_} = get_def_opt($_) unless exists $dlib->{$_};
+    for my $o (@default_dlib_opts) {
+        $dlib->{$o} = get_def_opt($o) unless exists $dlib->{$o};
     }
 
     # set macro-level WriteMakefile's values if weren't set already
     $args{macro} ||= {};
     my $macro = $args{macro};
-    for (@default_macro_opts) {
-        $macro->{$_} = get_def_opt($_) unless exists $macro->{$_};
+    for my $o (@default_macro_opts) {
+        $macro->{$o} = get_def_opt($o) unless exists $macro->{$o};
     }
 
     ExtUtils::MakeMaker::WriteMakefile(%args);