Author: stevehay Date: Fri Jun 21 07:36:43 2019 New Revision: 1861755 URL: http://svn.apache.org/viewvc?rev=1861755&view=rev Log: Fix Use-after-free segfault in ap_server_config_defines seen on start-up on OpenBSD
Reported by Sam Vaughan at https://bz.apache.org/bugzilla/show_bug.cgi?id=63516 Suggested fix by Joe Orton on that ticket. Modified: perl/modperl/trunk/src/modules/perl/mod_perl.c Modified: perl/modperl/trunk/src/modules/perl/mod_perl.c URL: http://svn.apache.org/viewvc/perl/modperl/trunk/src/modules/perl/mod_perl.c?rev=1861755&r1=1861754&r2=1861755&view=diff ============================================================================== --- perl/modperl/trunk/src/modules/perl/mod_perl.c (original) +++ perl/modperl/trunk/src/modules/perl/mod_perl.c Fri Jun 21 07:36:43 2019 @@ -861,7 +861,7 @@ void modperl_register_hooks(apr_pool_t * /* for <IfDefine MODPERL2> and Apache2->define("MODPERL2") */ *(char **)apr_array_push(ap_server_config_defines) = - apr_pstrdup(p, "MODPERL2"); + apr_pstrdup(ap_server_config_defines->pool, "MODPERL2"); ap_hook_pre_config(modperl_hook_pre_config, NULL, NULL, APR_HOOK_MIDDLE);