Hi Stas, Thanks. I'll fold these changes and release on CPAN. I'll also remove the $|=1 setting, since that was globally needed for FastCGI compatibility, and I don't think that anyone uses it anymore.
Lincoln On Monday 10 March 2003 08:43 pm, Stas Bekman wrote: > Hi Lincoln, > > > I'm not interested in modifying CGI.pm to use MP2 until I start using MP2 > > myself. This isn't likely in the near future, since I'm very happy > > indeed with MP1/Apache1. > > I've done the porting of CGI.pm, CGI::Carp and CGI::Pretty (no more > Apache/compat.pm). I did some basic testing, however it'd be nice if people > were to test this patch and confirm that I didn't break anything that did > work before. So that Lincoln doesn't have to figure out how to test it. > > I've attached the diff against 2.91 distro. > > One more thing, Lincoln, why CGI.pm does: > > $| = 1; > > without localizing the change, when running under mod_perl? This has a > potentially bad effect on the rest of the modules running under the same > server, since now every print() will flush the data. Can this setting be > localized (this will probably require to move the unbuffering where it's > relevant, rather than globally)? > > Thanks. > > __________________________________________________________________ > Stas Bekman JAm_pH ------> Just Another mod_perl Hacker > http://stason.org/ mod_perl Guide ---> http://perl.apache.org > mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com > http://modperlbook.org http://apache.org http://ticketmaster.com -- ======================================================================== Lincoln D. Stein Cold Spring Harbor Laboratory [EMAIL PROTECTED] Cold Spring Harbor, NY ========================================================================
