Geoffrey Young wrote:

ok, I think I've decided that ignoring errors from :server or :args_how isn't a good idea - it's better to have that blow up on a user than have an unresolved error later on.

+1


so, if we're not supporting everything right now, this is probably a better patch.

--- lib/Apache/compat.pm        30 Aug 2003 02:33:26 -0000      1.88
+++ lib/Apache/compat.pm        21 Oct 2003 17:57:07 -0000
@@ -148,7 +148,15 @@
 sub import {
     my $class = shift;
     my $package = scalar caller;
-    Apache::Const->compile($package => @_);
+
+    my @args = @_;
+
+    # treat :response as :common - it's not perfect
+    # (and we may import :common twice), but it's
+    # simple and close enough for the majority
+    @args = map { s/:response/:common/; $_ } @args;

if :response and :common come in the same import() this will do:


my %seen = ();
my @args = grep { $seen{$_}++; $seen{$_} < 2 } map { /^:response$/ ? ":common" : $_ } @_;


or something like that ;)


__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com



Reply via email to