--- Stas Bekman <[EMAIL PROTECTED]> wrote: > Sreeji K
Das wrote:
> mod_perl build currently requires that 
> makepl_args.mod_perl is present in one of 
> > current, '..' or $ENV{HOME}.
> ...<snip>

> Why not do the simple:
> 
> perl Makefile.PL `cat
> /whereever/your/file/is/makepl_args.mod_perl`

Then I lose the flexibility of having comments & neat
formatting in the config. file. I'll have to escape
all the newlines. Also, this works only on Unices.

Comparitively,
perl Makefile.PL
MAKEPL_ARGS_FILE=/whereever/your/file/is/makepl_args.mod_perl

looks better (IMHO).

Sreeji

The unified diff., if you agree:
----------------------
--- Makefile.PL.org     Mon Nov  3 23:09:47 2003
+++ Makefile.PL Tue Nov  4 01:22:49 2003
@@ -193,6 +193,7 @@
     NONE => "", 
 );          
 
+$MAKEPL_ARGS_FILE = '';
 $LIBPERL = "DEFAULT";
 $USE_APACI = $USE_DSO = $USE_APXS = 0;
 $WITH_APXS = "";
@@ -303,8 +304,12 @@
 my @mm_args;
 {
     my($fh,$file);
-    for (qw(./ ../ ./. ../.), "$ENV{HOME}/.") {
-       last if $fh = FileHandle->new($file =
$_."makepl_args.mod_perl");
+    foreach (@ARGV) {
+       $MAKEPL_ARGS_FILE = $1, last if
s/^MAKEPL_ARGS_FILE=(.*)//;
+       }
+    for ($MAKEPL_ARGS_FILE, qw(./ ../ ./. ../.),
"$ENV{HOME}/.") {
+       $file = -d $_ ? $_ . "/makepl_args.mod_perl" :
$_;
+       last if $fh = FileHandle->new($file);
     }
     if($fh) {
        print "Reading Makefile.PL args from $file\n";


________________________________________________________________________
Want to chat instantly with your online friends?  Get the FREE Yahoo!
Messenger http://mail.messenger.yahoo.co.uk

-- 
Reporting bugs: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html

Reply via email to