On Tue, 25 Nov 2003 15:47:07 -0500
Geoffrey Young <[EMAIL PROTECTED]> wrote:

> > I'll
> > take a look at 1.0 "soonish" 
> 
> it looks like the logic is pretty much the same in 1.0 as well.
> 
> please try this (untested) patch and let me know if it fixes things for you.
> 
> --Geoff
> 
> Index: src/modules/perl/Apache.xs
> ===================================================================
> RCS file: /home/cvspublic/modperl/src/modules/perl/Apache.xs,v
> retrieving revision 1.129
> diff -u -r1.129 Apache.xs
> --- src/modules/perl/Apache.xs  16 Sep 2003 19:51:06 -0000      1.129
> +++ src/modules/perl/Apache.xs  25 Nov 2003 20:39:41 -0000
> @@ -2084,7 +2084,7 @@
>                                                  &perl_module);
>         TABLE_GET_SET(c->vars, FALSE);
>      }
> -    if (!SvTRUE(RETVAL)) {
> +    if (!SvOK(RETVAL)) {
>         s = r && r->server ? r->server : perl_get_startup_server();
>         if (s && s->module_config) {
>             SvREFCNT_dec(RETVAL); /* in case above did newSV(0) */
> 

Hi Geoff,
the patch seems to work fine.
I've applied it over mp 1.29 (with Apache 1.3.28)

Thanks

by

        - Enrico


-- 
Reporting bugs: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html

Reply via email to