"Swen Schillig" <[EMAIL PROTECTED]> writes: > Joe > > Thanks for the patch the expiration is working fine now > even though the test fails :-) > > > t/testall -v > All APREQ Tests: > Cookie: ..F. > Param: ... > Parsers: .. > > 9 tests run: 8 passed, 1 failed, 0 not implemented. > > Failed tests in Cookie: > 1) netscape_cookie: expected > ----> > foo=bar; path=/quux; domain=example.com; expires=Thu, 18-Dec-2003 11:51:26 > GMT > <---- > but saw > ----> > foo=bar; path=/quux; domain=example.com; expires=Fri, 17-Dec-2004 11:50:55 > GMT > <----
The failure shows that apreq_expires is broken also. The fix is identical - wrap apr_time_from_sec around the result of apreq_atoi64t. > While testing this I figured another problem, the secure flag > is not working either ! Oops! > But the path and the domain attributes are ! > So maybe you'll find some time to fix this as well :-) > > Anyway, thanks for your help and the solution. > > BTW, when will the fix be part of the cvs ? The fixes are ready; what's missing are the corresponding tests to ensure the bugs don't reappear. nb- folks can always add more tests to demonstrate bugs without necessarily having a corresponding fix. A patch to the test suite which demonstrates a bug is absolutely the best kind of bug report. -- Joe Schaefer -- Reporting bugs: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html
