"Beau E. Cox" <[EMAIL PROTECTED]> writes: [...]
> The only place in my Mason changes I can see anything funny is: > > # This gets the proper request object all in one fell swoop. We > # don't want to copy it because if we do something like assign an > # Apache::Request object to a variable currently containing a > # plain Apache object, we leak memory. This means we'd have to > # use multiple variables to avoid this, which is annoying. > my $r = > $r_sub->( $self->args_method eq 'mod_perl' ? > Apache::Request->new( $_[0] ) : > $_[0] > ); > > I changed: > Apache::Request->instance( $_[0] ) : > to: > Apache::Request->new( $_[0] ) : > > Is that causing trouble? No, your change is fine. AFAICT that comment pertains to an esoteric problem with object cleanup in libapreq/mp1, but the bug doesn't seem to be carried over into mp2/apreq2 (the apreq2 test suite has a test for it). -- Joe Schaefer -- Reporting bugs: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html List etiquette: http://perl.apache.org/maillist/email-etiquette.html
