Fred Moyer wrote:
I really have no idea about Apache-AuthenNTLM but to make it working
again you could apply the patch below and rebuilt your mod-perl.


As far
as I can tell from the last mail from Stas it's going to be
read/writeable in future if one volunteers to write tests :-).


I originally suggested that change as a result of reviewing the map
structures after running into this same problem on a different method of a
read only accessor breaking an existing module.  So I am due some flak
here for suggesting other methods be read-only, as it has broken something
else.  Maybe I can volunteer to write tests for those methods as a way of
making amends.

Actually, when I think more about this, it's a bad idea to have those values to be changed by any module. What if you have a keepalive connection, and some other, unrelated request comes in following the request that set some connection records values? Could that be a problem? I haven't looked at what this module does, so I can't tell, whether it's safe or not.


Here's a patch for AuthenNTLM.pm which uses $conn->notes, instead of
modifying $conn->remote_host, to compare the connections.  I don't have a
working NTLM setup but maybe give this a go and see how it works.

That sounds like a much safer solution. Just because you could modify the connection record before, it doesn't mean that it's the right thing to do.


I've turned quite a few fields to read-only exactly because of this, as there should be a good reason for having those writable, and once there is one we will open those up.


-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

--
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html



Reply via email to