William McKee wrote: > On Wed, Aug 31, 2005 at 11:54:57AM -0400, Geoffrey Young wrote: > >>$self->{httpd_basedir}, which looks to be calculated based on the location >>of the httpd binary. but it looks like it ought to be using HTTPD_ROOT >>instead. at least if it's defined. >> >>try this (completely untested) > > > Perfect! That worked just fine. How can we get it added to A::T?
I've been thinking a bit about this and I think the attached is a better patch. basically, I think A-T goes through a lot of effort to separate the current filesystem configuration from the hard-coded stuff in httpd in an effort to make it easy to roll up an httpd install, move it someplace else, and still have A-T be able to create a worthy configuration. using HTTPD_ROOT like that kinda breaks all of that for people expecting the current behavior, so I'd rather use it as a last-ditch effort than off the bat. can you give it a whirl? --Geoff
Index: lib/Apache/TestConfigParse.pm =================================================================== --- lib/Apache/TestConfigParse.pm (revision 265514) +++ lib/Apache/TestConfigParse.pm (working copy) @@ -341,7 +341,7 @@ my $extra_file = $self->{vars}->{httpd_conf_extra}; unless ($file and -e $file) { - if (my $base = $self->{httpd_basedir}) { + if (my $base = $self->{httpd_defines}->{HTTPD_ROOT} || $self->{httpd_basedir}) { my $default_conf = $self->{httpd_defines}->{SERVER_CONFIG_FILE}; $default_conf ||= catfile qw(conf httpd.conf); $file = catfile $base, $default_conf;