fixed....
hth
--- Begin Message ---
The following reply was made to PR ports/134749; it has been noted by GNATS.
From: "Philip M. Gollucci" <pgollu...@p6m7g8.com>
To: bug-follo...@freebsd.org, Troy <t...@twisted.net>,
Tim Zingelman <zingel...@fnal.gov>
Cc:
Subject: Re: ports/134749: www/mod_perl bus error after 1.31 update
Date: Fri, 5 Jun 2009 01:59:26 -0400
--------------080902040507050309010103
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
I've committed the fix upstream. FBSD port next.
--------------080902040507050309010103
Content-Type: message/rfc822; name="svn commit: r781917 - in
/perl/modperl/branches/1.x: Changes src/modules/perl/mod_perl.c.eml"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename*0="svn commit: r781917 - in /perl/modperl/branches/1.x:
Changes";
filename*1=" src/modules/perl/mod_perl.c.eml"
Return-Path: <modperl-cvs-return-6354-pgollucci=p6m7g8....@perl.apache.org>
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
by piccollo.p6m7g8.net (8.14.3/8.14.3) with SMTP id n555vlEY078897
for <pgollu...@p6m7g8.com>; Fri, 5 Jun 2009 01:57:48 -0400 (EDT)
(envelope-from
modperl-cvs-return-6354-pgollucci=p6m7g8....@perl.apache.org)
Received: (qmail 38574 invoked by uid 500); 5 Jun 2009 05:57:42 -0000
Mailing-List: contact modperl-cvs-h...@perl.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:modperl-cvs-h...@perl.apache.org>
list-unsubscribe: <mailto:modperl-cvs-unsubscr...@perl.apache.org>
List-Post: <mailto:modperl-...@perl.apache.org>
Reply-To: d...@perl.apache.org
List-Id: <modperl-cvs.perl.apache.org>
Delivered-To: mailing list modperl-...@perl.apache.org
Received: (qmail 38565 invoked by uid 99); 5 Jun 2009 05:57:42 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2009 05:57:42 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4)
by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2009 05:57:39 +0000
Received: by eris.apache.org (Postfix, from userid 65534)
id 2C8A82388849; Fri, 5 Jun 2009 05:57:18 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r781917 - in /perl/modperl/branches/1.x: Changes
src/modules/perl/mod_perl.c
Date: Fri, 05 Jun 2009 05:57:18 -0000
To: modperl-...@perl.apache.org
From: pgollu...@apache.org
X-Mailer: svnmailer-1.0.8
Message-Id: <20090605055718.2c8a82388...@eris.apache.org>
X-Virus-Checked: Checked by ClamAV on apache.org
X-Virus-Scanned: ClamAV 0.94.2/9425/Thu Jun 4 23:55:18 2009 on
piccollo.p6m7g8.net
X-Virus-Status: Clean
X-Spam-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,
RCVD_IN_DNSWL_MED,SPF_PASS autolearn=ham version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on piccollo.p6m7g8.net
Author: pgollucci
Date: Fri Jun 5 05:57:17 2009
New Revision: 781917
URL: http://svn.apache.org/viewvc?rev=781917&view=rev
Log:
Address FreeBSD PR: ports/134749
This is actually a bug in gcc 4.2.1?x where
the array is optimized incorrectly causing
sefaults during startup.
Apparently the bug does not exist in FreeBSD 8
but is an issue in 7.x.
Reported by: Troy <t...@twisted.net>
Submitted by: Tim Zingelman <zingel...@fnal.gov>
Reviewed by: myself
Modified:
perl/modperl/branches/1.x/Changes
perl/modperl/branches/1.x/src/modules/perl/mod_perl.c
Modified: perl/modperl/branches/1.x/Changes
URL:
http://svn.apache.org/viewvc/perl/modperl/branches/1.x/Changes?rev=781917&r1=781916&r2=781917&view=diff
==============================================================================
--- perl/modperl/branches/1.x/Changes (original)
+++ perl/modperl/branches/1.x/Changes Fri Jun 5 05:57:17 2009
@@ -10,6 +10,10 @@
=item 1.32-dev
+Work around a gcc optimization specific bug which
+cuased seg faults on FreeBSD 7.x during mod_perl startup.
+[Tim Zingelman <zingel...@fnal.gov>]
+
=item 1.31 May 11, 2009
Fix static APACI build on Mac OS X. [Gozer]
Modified: perl/modperl/branches/1.x/src/modules/perl/mod_perl.c
URL:
http://svn.apache.org/viewvc/perl/modperl/branches/1.x/src/modules/perl/mod_perl.c?rev=781917&r1=781916&r2=781917&view=diff
==============================================================================
--- perl/modperl/branches/1.x/src/modules/perl/mod_perl.c (original)
+++ perl/modperl/branches/1.x/src/modules/perl/mod_perl.c Fri Jun 5 05:57:17
2009
@@ -596,6 +596,7 @@
void perl_startup (server_rec *s, pool *p)
{
char *argv[] = { NULL, NULL, NULL, NULL, NULL, NULL, NULL };
+ char **temp_argv=argv;
char **entries, *dstr;
int status, i, argc=1;
dPSRV(s);
@@ -679,7 +680,7 @@
MP_TRACE_g(fprintf(stderr, "..."));
#ifdef PERL_SYS_INIT
- PERL_SYS_INIT(&argc,(char***)&argv);
+ PERL_SYS_INIT(&argc,(char***)&temp_argv);
#endif
#ifndef perl_init_i18nl10n
--------------080902040507050309010103--
--- End Message ---
--- Begin Message ---
pgollucci 2009-06-05 06:23:06 UTC
FreeBSD ports repository
Modified files:
www/mod_perl Makefile
Added files:
www/mod_perl/files patch-src__modules__perl__mod_perl.c
Log:
- Fix a segfault in mod_perl startup due to a bug
in gcc related optimizations.
- Fixed upstream in branches/1...@r781917
- Bump PORTREVISION
PR: ports/13479
Reported by: Troy <t...@twisted.net>
Submitted by: Tim Zingelman <zingel...@fnal.gov>
Revision Changes Path
1.43 +1 -0 ports/www/mod_perl/Makefile
1.1 +19 -0
ports/www/mod_perl/files/patch-src__modules__perl__mod_perl.c (new)
http://cvsweb.FreeBSD.org/ports/www/mod_perl/files/patch-src__modules__perl__mod_perl.c?rev=1.1&content-type=text/x-cvsweb-markup
http://cvsweb.FreeBSD.org/ports/www/mod_perl/Makefile.diff?r1=1.42&r2=1.43&f=h
| --- ports/www/mod_perl/Makefile 2009/05/16 06:27:51 1.42
| +++ ports/www/mod_perl/Makefile 2009/06/05 06:23:06 1.43
| @@ -2,11 +2,12 @@
| # Date created: November 5th 1999
| # Whom: Sheldon Hearn
<sheld...@freebsd.org>
| #
| -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/www/mod_perl/Makefile,v
1.42 2009/05/16 06:27:51 pgollucci Exp $
| +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/www/mod_perl/Makefile,v
1.43 2009/06/05 06:23:06 pgollucci Exp $
| #
|
| PORTNAME= mod_perl
| PORTVERSION= 1.31
| +PORTREVISION= 1
| CATEGORIES= www perl5
| MASTER_SITES= CPAN
| MASTER_SITE_SUBDIR= ModPerl/GOZER
--- End Message ---
