Another one to ponder :)
Bill
----- Original Message -----
From: "Alexey Panchenko" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Thursday, July 26, 2001 7:10 AM
Subject: mod_proxy/8090: CacheForceCompletion directive don't work
>
> >Number: 8090
> >Category: mod_proxy
> >Synopsis: CacheForceCompletion directive don't work
> >Confidential: no
> >Severity: serious
> >Priority: medium
> >Responsible: apache
> >State: open
> >Quarter:
> >Keywords:
> >Date-Required:
> >Class: sw-bug
> >Submitter-Id: apache
> >Arrival-Date: Thu Jul 26 05:20:00 PDT 2001
> >Closed-Date:
> >Last-Modified:
> >Originator: [EMAIL PROTECTED]
> >Release: 1.3.20
> >Organization:
> apache
> >Environment:
> Bug is not platform specific
> >Description:
> CacheForceCompletion directive don't work
> >How-To-Repeat:
>
> >Fix:
> in mod_proxy.c:
> static const char *
> set_cache_completion(cmd_parms *parms, void *dummy, char *arg)
> {
> proxy_server_conf *psf =
> ap_get_module_config(parms->server->module_config, &proxy_module);
> int s = atoi(arg);
> if (s > 100 || s < 0) {
> return "CacheForceCompletion must be <= 100 percent, "
> "or 0 for system default.";
> }
>
> if (s > 0)
> psf->cache.cache_completion = ((float)s / 100);
>
> - psf->cache.cache_completion = 1;
> + psf->cache.cache_completion_set = 1;
> return NULL;
> }
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> [In order for any reply to be added to the PR database, you need]
> [to include <[EMAIL PROTECTED]> in the Cc line and make sure the]
> [subject line starts with the report component and number, with ]
> [or without any 'Re:' prefixes (such as "general/1098:" or ]
> ["Re: general/1098:"). If the subject doesn't match this ]
> [pattern, your message will be misfiled and ignored. The ]
> ["apbugs" address is not added to the Cc line of messages from ]
> [the database automatically because of the potential for mail ]
> [loops. If you do not include this Cc, your reply may be ig- ]
> [nored unless you are responding to an explicit request from a ]
> [developer. Reply only with text; DO NOT SEND ATTACHMENTS! ]
>
>
>
>
--- Begin Message ---
The following reply was made to PR mod_proxy/8090; it has been noted by GNATS.
From: Alexey Panchenko <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Cc:
Subject: Re: mod_proxy/8090: CacheForceCompletion directive don't work
Date: Thu, 26 Jul 2001 21:36:18 +0700
Additional fix, applying to PR #7383 "when the client disconnects the
proxy will continue to read the content, despite there being no need
for it".
In proxy_util.c (function ap_proxy_send_fb):
@@ -593,5 +593,5 @@
if (w <= 0) {
- if (c != NULL && c->fp != NULL) {
+ if (c != NULL) {
/* when a send failure occurs, we need to decide
* whether to continue loading and caching the
* document, or to abort the whole thing
@@ -603,6 +603,8 @@
if (! ok) {
+ if (c->fp!=NULL) {
ap_pclosef(c->req->pool, ap_bfileno(c->fp, B_WR));
c->fp = NULL;
+ }
unlink(c->tempfile);
c = NULL;
}
--
Best regards,
Alexey mailto:[EMAIL PROTECTED]
--- End Message ---
