All,

I was looking through proxy_cache.c.  We are currently making changes to the
proxy cache code such that it can retain a file permanently.  We call it
guaranteed cache.  We also have a populator that will pre populate the cache
with files.  This comes in handy if you want to distribute large video files to
remote sites over relatively slow links.  Where the file is say 40 megs and the
line is say 128k.  We would be happy to post the patches once they are complete,
if anyone is interested.  I can provide more info also if anyone has any
questions regarding this topic.

During our testing phase we noticed a problem with proxy_cache.c, line 1157.  It
seems that Cache-Control: max-age=0, or Cache-Control: of any kind in the
request would not have been fully functional (at minimum) without this change.

    /* extract max-age from request */
    if (cc_cresp && ap_proxy_liststr(cc_req, "max-age", &val))
        maxage_req =  atoi(val);
    else
        maxage_req = -1;
 
It seems to me this should be:

   /* extract max-age from request */
    if (cc_req && ap_proxy_liststr(cc_req, "max-age", &val))
        maxage_req =  atoi(val);
    else
        maxage_req = -1;

I have attached the patch.

Thanks for your time,

Geff

Attachment: proxy_cache.c.diff
Description: Binary data

Reply via email to