Eric:

This looks promising. I suspect you're mainly looking for feedback on the interface, which I haven't really looked at yet. But in testing it 3 of the 4 test files were skipped. Perhaps that's okay for a distribution in the experimental stage, but I know that it would give me pause if I were thinking about installing it from CPAN.

> [work] 502 $ svn checkout http://scratchcomputing.com/svn/list/trunk/ wilhelm
> A  wilhelm/t
> A  wilhelm/t/03-prereq.t

Checks out into Subversion nicely!
[snip]

> [work] 503 $ cd wilhelm

[snip]

> [wilhelm] 507 $ perl Build.PL
> Checking whether your kit is complete...
> Warning: the following files are missing in your kit:
>         META.yml
> Please inform the author.
> Creating new 'Build' script for 'list' version '0.01'
> [wilhelm] 508 $ ./Build
> lib/list.pm -> blib/lib/list.pm
> Manifying blib/lib/list.pm -> blib/libdoc/list.3
> [wilhelm] 509 $ ./Build test
> t/00-load............ok 1/1# Testing list 0.01 > t/00-load............ok
> t/01-pod-coverage....skipped
>         all skipped: $ENV{TEST_POD_COVERAGE} is not set
> t/02-pod.............skipped
>         all skipped: $ENV{TEST_POD} is not set

Should a user really have to have these two environmental variables set in order to use this module?

> t/03-prereq..........skipped
>         all skipped: Test::Prereq::Build required to test dependencies
> All tests successful, 3 tests skipped.

> Files=4, Tests=1,  2 wallclock secs ( 0.73 cusr +  0.16 csys =  0.89 CPU)

And looking at the one test that does run ...

> [wilhelm] 510 $ prove -vb t/00-load.t
> t/00-load....1..1
> ok 1 - use list;
> ok
> All tests successful.
> Files=1, Tests=1,  0 wallclock secs ( 0.10 cusr +  0.06 csys =  0.16 CPU)

... we see that the functionality is not yet tested.

jimk

Reply via email to