On Thu, 21 Jan 2010 13:03:25 +1100 rolfy <[email protected]> wrote: ... > Anyway, I'd be interested to know if people think that Debug::Print > is an appropriate name for this module...
There's a lot more to an interface, than simply its name. I'd consider your configuration keys a part of that interface. I notice you've used "Hungarian" notation on them; prefixing each key with a letter to give an indication of type. We don't really do that in perl; if your module did that it would feel somewhat out of place here. I'd suggest instead using all-lower for the names... debug_mode test_mode verbose_mode ... The usual naming conventions in perl are CONSTANT_NAME ClassName member_name. > Constructive feedback is always something I'm happy to receive... It's nice to see you thinking about interface ideas, though. It's something I think is greatly overlooked; so often people will think up a brilliant piece of code, then stick it behind an awful interface. I'd much prefer the other way around: given a nice interface it doesn't matter how bad the code is behind it; your next upload can always fix implementation bugs. Whereas, no matter how good the code is, if it's behind a poor interface that people start using, you're stuck supporting those bad ideas forever. Hope that helps, -- Paul "LeoNerd" Evans [email protected] ICQ# 4135350 | Registered Linux# 179460 http://www.leonerd.org.uk/
signature.asc
Description: PGP signature
