Re: Request for feedback: interface to 06perms.txt

[Shlomi Fish]

Hi Neil,

thanks for your contribution. See below for my comments.

On Fri, 12 Oct 2012 09:54:28 +0100
Neil Bowers <n...@bowers.com> wrote:

> I've created an interface to PAUSE's 06perms.txt file, which
> currently contains two classes:
> 
> PAUSE::PermissionsFile
> Module::Permissions

Preferably, those two classes should be under the same namespace.

> 
> Here's example usage:
> 
> use PAUSE::PermissionsFile;
> 
> $pp = PAUSE::PermissionsFile->new;
> $mp = $pp->module_permissions('HTTP::Client');
> 
> $owner    = $mp->owner;
> @comaints = $mp->co_maintainers;
> 
> print "owner   : $owner\n";
> print "comaint : @comaints\n", 
> 

It would be a good idea to add "my" to the synposis, so as to make it
"use strict;"/"use warnings;"-compliant.

> Which would print:
> 
> owner   : LINC
> comaint : NEILB
> 
> By default PAUSE::PermissionsFile will mirror (using HTTP::Tiny's
> mirror) 06perms.txt, and then work off the local copy. 

I would suggest against contacting remote sites by default, due to
the "Test programs should not connect to Internet resources" item here:

http://www.shlomifish.org/open-source/resources/how-to-contribute-to-my-projects/HACKING.html

Regards,

        Shlomi Fish

> You can pass a
> path to the constructor, if you've got your own local copy anyway.
> The module_permissions method returns an instance of
> Module::Permissions for the named module. This lets you get at the
> individual 'm', 'f', and 'c' entries for the module, but also
> provides the 'owner' concept ('m' if there is one, otherwise 'f').
> 
> I'd be happy to hear any thoughts on:
> naming
> design of the interface
> other features you think this might need
> Cheers,
> Neil
> 



-- 
-----------------------------------------------------------------
Shlomi Fish       http://www.shlomifish.org/
List of Text Editors and IDEs - http://shlom.in/IDEs

Yesterday I asked one of my students if she knew what an encyclopedia is, and
she said: “Is it something like Wikipedia?”.
        — http://twitter.com/alisonclement/status/8421314259

Please reply to list if it's a mailing list post - http://shlom.in/reply .