Author: kwilliams
Date: Thu Aug 3 20:37:07 2006
New Revision: 6746
Added:
CPANPLUS-Dist-Build/trunk/Changes
Modified:
CPANPLUS-Dist-Build/trunk/lib/CPANPLUS/Dist/Build.pm
Log:
Don't send a 'pass' report just because --force is in effect
Added: CPANPLUS-Dist-Build/trunk/Changes
==============================================================================
--- (empty file)
+++ CPANPLUS-Dist-Build/trunk/Changes Thu Aug 3 20:37:07 2006
@@ -0,0 +1,6 @@
+Revision history for Perl extension CPANPLUS::Dist::Build.
+
+0.03
+
+ - We were sending cpantesters 'pass' reports whenever --force was in
+ effect, which is probably not the right thing to do. [Jos Boumans]
Modified: CPANPLUS-Dist-Build/trunk/lib/CPANPLUS/Dist/Build.pm
==============================================================================
--- CPANPLUS-Dist-Build/trunk/lib/CPANPLUS/Dist/Build.pm (original)
+++ CPANPLUS-Dist-Build/trunk/lib/CPANPLUS/Dist/Build.pm Thu Aug 3
20:37:07 2006
@@ -472,7 +472,7 @@
my %buildflags = $dist->_buildflags_as_hash( $buildflags );
$dist->status->_buildflags( $buildflags );
- my $fail; my $prereq_fail;
+ my $fail; my $prereq_fail; my $test_fail;
RUN: {
### this will set the directory back to the start
@@ -542,7 +542,7 @@
if( $conf->get_conf('cpantest') and not $prereq_fail ) {
$cb->_send_report(
module => $self,
- failed => $fail,
+ failed => $test_fail || $fail,
buffer => CPANPLUS::Error->stack_as_string,
verbose => $verbose,
force => $force,
@@ -595,6 +595,10 @@
my $dir;
unless( $dir = $self->status->extract ) {
+ ### mark specifically *test* failure.. so we dont
+ ### send success on force...
+ $test_fail++;
+
error( loc( "No dir found to operate on!" ) );
return;
}
