Author: kwilliams
Date: Tue Oct 30 11:27:11 2007
New Revision: 10138
Modified:
Module-Build/trunk/Changes
Module-Build/trunk/lib/Module/Build/Base.pm
Module-Build/trunk/t/runthrough.t
Log:
Fix bug in checking for Archive::Tar in tests
Modified: Module-Build/trunk/Changes
==============================================================================
--- Module-Build/trunk/Changes (original)
+++ Module-Build/trunk/Changes Tue Oct 30 11:27:11 2007
@@ -1,5 +1,8 @@
Revision history for Perl extension Module::Build.
+ - Fixed our check for Archive::Tar in the t/runthrough.t test, which
+ fixes a common failure on Win32. [Spotted by Chris Williams]
+
- Fixed a File::Spec mal-ism in t/destinations.t [Craig A. Berry]
- Exposed the internal ExtUtils::CBuilder object as part of our API,
Modified: Module-Build/trunk/lib/Module/Build/Base.pm
==============================================================================
--- Module-Build/trunk/lib/Module/Build/Base.pm (original)
+++ Module-Build/trunk/lib/Module/Build/Base.pm Tue Oct 30 11:27:11 2007
@@ -1285,7 +1285,7 @@
my $status = $self->check_installed_status($modname, $spec);
if ($status->{ok}) {
- return $status->{have} if $status->{have} and $status->{have} ne '<none>';
+ return $status->{have} if $status->{have} and "$status->{have}" ne
'<none>';
return '0 but true';
}
Modified: Module-Build/trunk/t/runthrough.t
==============================================================================
--- Module-Build/trunk/t/runthrough.t (original)
+++ Module-Build/trunk/t/runthrough.t Tue Oct 30 11:27:11 2007
@@ -149,7 +149,7 @@
SKIP: {
skip( "not sure if we can create a tarball on this platform", 1 )
- unless $mb->check_installed_status('Archive::Tar', 0) ||
+ unless $mb->check_installed_version('Archive::Tar', 0) ||
$mb->isa('Module::Build::Platform::Unix');
$mb->add_to_cleanup($mb->dist_dir . ".tar.gz");
