[svn:Module-Build] r11882 - in Module-Build/trunk: . lib/Module/Build

[schwern]

Author: schwern
Date: Thu Sep 25 16:02:58 2008
New Revision: 11882

Modified:
   Module-Build/trunk/   (props changed)
   Module-Build/trunk/lib/Module/Build/Base.pm

Log:
 [EMAIL PROTECTED]:  schwern | 2008-09-25 19:02:50 -0400
 Revert the decomplexing of check_autofeatures, it was done during a code
 freeze and is holding up release.  Just initialize $max_name_len to fix 
 the warning.


Modified: Module-Build/trunk/lib/Module/Build/Base.pm
==============================================================================
--- Module-Build/trunk/lib/Module/Build/Base.pm (original)
+++ Module-Build/trunk/lib/Module/Build/Base.pm Thu Sep 25 16:02:58 2008
@@ -1085,9 +1085,9 @@
   $self->log_info("Checking features:\n");
 
   my $max_name_len = 0;
-  for my $name (keys %$features) {
-      $max_name_len = max( length($name), $max_name_len );
-  }
+  $max_name_len = ( length($_) > $max_name_len ) ?
+                    length($_) : $max_name_len
+    for keys %$features;
 
   while (my ($name, $info) = each %$features) {
     $self->log_info("  $name" . '.' x ($max_name_len - length($name) + 4));
@@ -1115,11 +1115,6 @@
   $self->log_warn("\n");
 }
 
-sub max {
-    my($a, $b) = @_;
-    return $a > $b ? $a : $b;
-}
-
 sub prereq_failures {
   my ($self, $info) = @_;