Author: ericwilhelm
Date: Tue Dec 16 15:01:41 2008
New Revision: 12175
Modified:
Module-Build/trunk/Changes
Module-Build/trunk/lib/Module/Build/Base.pm
Log:
lib/Module/Build/Base.pm - skip calling get_options() as a class method
Changes - clarify the deprecation of attributes-as-class-method
Modified: Module-Build/trunk/Changes
==============================================================================
--- Module-Build/trunk/Changes (original)
+++ Module-Build/trunk/Changes Tue Dec 16 15:01:41 2008
@@ -1,5 +1,10 @@
Revision history for Perl extension Module::Build.
+0.31 - Tue Dec 16 14:59:05 PST 2008
+
+ - Use of attributes as class methods is deprecated (this was never a
+ documented feature and appears to only have worked accidentally.)
+
0.30_02 - Mon Dec 15 12:23:55 PST 2008
Bug Fixes
Modified: Module-Build/trunk/lib/Module/Build/Base.pm
==============================================================================
--- Module-Build/trunk/lib/Module/Build/Base.pm (original)
+++ Module-Build/trunk/lib/Module/Build/Base.pm Tue Dec 16 15:01:41 2008
@@ -1594,6 +1594,9 @@
my $self = shift;
my (@argv) = @_;
+ # XXX is it even valid to call this as a class method?
+ return({}, @argv) unless(ref($self)); # no object
+
my $specs = $self->get_options;
return({}, @argv) unless($specs and %$specs); # no user options
