Author: dagolden
Date: Mon Sep 7 18:52:12 2009
New Revision: 13287
Added:
Module-Build/trunk/t/actions/
Module-Build/trunk/t/actions/installdeps.t (contents, props changed)
Modified:
Module-Build/trunk/lib/Module/Build/Base.pm
Log:
added rudimentary installdeps tests
Modified: Module-Build/trunk/lib/Module/Build/Base.pm
==============================================================================
--- Module-Build/trunk/lib/Module/Build/Base.pm (original)
+++ Module-Build/trunk/lib/Module/Build/Base.pm Mon Sep 7 18:52:12 2009
@@ -1327,7 +1327,6 @@
EOF
unless ( $ENV{PERL5_CPANPLUS_IS_RUNNING} || $ENV{PERL5_CPAN_IS_RUNNING} ) {
- my $client = $self->cpan_client;
$self->log_info(
"Run 'Build installdeps' to install missing prerequisites.\n\n"
);
@@ -3180,6 +3179,10 @@
}
}
+ if ( ! -x $command ) {
+ die "cpan_client '$command' is not executable\n";
+ }
+
$self->do_system($command, @opts, @install);
}
Added: Module-Build/trunk/t/actions/installdeps.t
==============================================================================
--- (empty file)
+++ Module-Build/trunk/t/actions/installdeps.t Mon Sep 7 18:52:12 2009
@@ -0,0 +1,47 @@
+use strict;
+use lib $ENV{PERL_CORE} ? '../lib/Module/Build/t/lib' : 't/lib';
+use MBTest;
+use DistGen;
+
+plan tests => 7;
+
+# Ensure any Module::Build modules are loaded from correct directory
+blib_load('Module::Build');
+
+# create dist object in a temp directory
+# enter the directory and generate the skeleton files
+my $dist = DistGen->new->chdir_in;
+
+$dist->change_build_pl(
+ module_name => $dist->name,
+ requires => {
+ 'File::Spec' => 9999,
+ },
+ build_requires => {
+ 'Getopt::Long' => 9998,
+ },
+ cpan_client => 'perl -le print($_)for($^X,@ARGV)',
+)->regen;
+
+# get a Module::Build object and test with it
+my $mb;
+stdout_stderr_of( sub { $mb = $dist->new_from_context('verbose' => 1) } );
+isa_ok( $mb, "Module::Build" );
+like( $mb->cpan_client, qr/^perl/, "cpan_client is mocked with perl" );
+
+my $out = stdout_of( sub {
+ $dist->run_build('installdeps')
+});
+ok( length($out), "ran mocked Build installdeps");
+like( $out, qr/$^X/, "relative cpan_client resolved relative to \$^X" );
+like( $out, qr/File::Spec/, "saw File::Spec prereq" );
+like( $out, qr/Getopt::Long/, "saw Getopt::Long prereq" );
+
+$out = stdout_stderr_of( sub {
+ $dist->run_build('installdeps', '--cpan_client', 'ADLKASJDFLASDJ')
+});
+like( $out, qr/cpan_client .* is not executable/,
+ "Build installdeps with bad cpan_client dies"
+);
+
+# vim:ts=2:sw=2:et:sta:sts=2
