Author: dagolden
Date: Tue Nov 10 04:16:34 2009
New Revision: 13481
Modified:
Module-Build/trunk/lib/Module/Build/Base.pm
Log:
fix bugs in last commit
Modified: Module-Build/trunk/lib/Module/Build/Base.pm
==============================================================================
--- Module-Build/trunk/lib/Module/Build/Base.pm (original)
+++ Module-Build/trunk/lib/Module/Build/Base.pm Tue Nov 10 04:16:34 2009
@@ -4041,25 +4041,27 @@
foreach (qw(dist_name dist_version dist_author dist_abstract license)) {
(my $name = $_) =~ s/^dist_//;
$add_node->($name, $self->$_());
- my $err = "ERROR: Missing required field '$_' for metafile\n"
- unless defined($node->{$name}) && length($node->{$name});
- if ( $fatal ) {
- die $err;
- }
- else {
- $self->log_warn($msg);
+ unless ( defined($node->{$name}) && length($node->{$name}) ) {
+ my $err = "ERROR: Missing required field '$_' for metafile\n";
+ if ( $fatal ) {
+ die $err;
+ }
+ else {
+ $self->log_warn($err);
+ }
}
}
- $node->{version} = $self->normalize_version($node->{version});
+ $node->{version} = $self->normalize_version($node->{version});
if (defined( my $l = $self->license )) {
- my $err = "Unknown license string '$l'"
- unless exists $self->valid_licenses->{ $l };
- if ( $fatal ) {
- die $err;
- }
- else {
- $self->log_warn($msg);
+ unless ( exists $self->valid_licenses->{ $l } ) {
+ my $err = "Unknown license string '$l'";
+ if ( $fatal ) {
+ die $err;
+ }
+ else {
+ $self->log_warn($err);
+ }
}
if (my $key = $self->valid_licenses->{ $l }) {
