Author: dagolden
Date: Thu Nov 19 05:53:36 2009
New Revision: 13569

Modified:
   Module-Build/trunk/Changes
   Module-Build/trunk/t/bundle_inc.t

Log:
fix bundle_inc.t for Win32

Modified: Module-Build/trunk/Changes
==============================================================================
--- Module-Build/trunk/Changes  (original)
+++ Module-Build/trunk/Changes  Thu Nov 19 05:53:36 2009
@@ -1,6 +1,11 @@
 Revision history for Perl extension Module::Build.
 
-0.35_10 - 
+0.35_10 -
+
+ Bug fixes:
+
+ - bundle_inc.t is more careful about permissions and open filehandles
+   to avoid failures/skips on Win32 [David Golden]
 
 0.35_09 - Thu Nov 19 01:30:42 EST 2009
 

Modified: Module-Build/trunk/t/bundle_inc.t
==============================================================================
--- Module-Build/trunk/t/bundle_inc.t   (original)
+++ Module-Build/trunk/t/bundle_inc.t   Thu Nov 19 05:53:36 2009
@@ -74,10 +74,11 @@
 );
 
 # Force bundled M::B to a higher version so it gets loaded
-# This has failed on Win32 for no known reason, so we'll skip if
+# This has failed on Win32 for various reasons, so we'll skip if
 # we can't edit the file.
 
 eval {
+  chmod 0644, $mb_file; # seem to need this on Win32
   my $fh;
   $fh = IO::File->new($mb_file, "<") or die "Could not read $mb_file: $!";
   my $mb_code = do { local $/; <$fh> };
@@ -99,11 +100,13 @@
 
   stdout_of( sub { Module::Build->run_perl_script('Build.PL',[],[]) } );
 
-  my $meta = IO::File->new('MYMETA.yml');
-  ok( $meta, "found MYMETA.yml" );
-  ok( scalar( grep { /generated_by:.*9999/ } <$meta> ),
-    "dist_dir Build.PL loaded bundled Module::Build"
-  );
+  {
+    my $meta = IO::File->new('MYMETA.yml');
+    ok( $meta, "found MYMETA.yml" );
+    ok( scalar( grep { /generated_by:.*9999/ } <$meta> ),
+      "dist_dir Build.PL loaded bundled Module::Build"
+    );
+  }
 
   #--------------------------------------------------------------------------#
   # test identification of dependencies

Reply via email to