# from Zefram
# on Thursday 25 October 2007 11:26:
>this patch just does a translation if a v1.2-style no_index
> setting was supplied.
1. I think we should officially deprecate dir WRT Build.PL
Meaning: die if both exist, warn if 'dir' but not 'directory'.
Later versions (say spec ~1.4) should just die if 'dir'.
2. This code will put them both in META.yml if they both exist.
(Though this is rendered moot if we do the above.)
3. why bother with the dereference?
+ if(exists($no_index->{dir}) && !exists($no_index->{directory})) {
+ $no_index = { %$no_index };
+ $no_index->{directory} = delete($no_index->{dir});
+ }
Other than that, it's good. If I get no feedback today, I'll apply it
with some changes for the deprecation.
We have no documentation coverage for this?
Aside: #1 also raises the question of what META.yml consumers should be
doing. Given that 1.3 removes (does not deprecate) 'dir', they
probably feel free to ignore it or even throw an error -- but the meta
spec doesn't make any recommendations about treatment of unspecified
keys.
Thanks,
Eric
--
software: a hypothetical exercise which happens to compile.
---------------------------------------------------
http://scratchcomputing.com
---------------------------------------------------
