On Nov 7, 2007, at 6:31 AM, John Peacock wrote:

Ken Williams wrote:
  if ($args{makefile_env_macros}) {
    require Module::Build::Compat;
%args = (%args, Module::Build::Compat- >makefile_to_build_macros);
  }

It shouldn't be doing that.  makefile_to_build_macros() returns args
suitable for the command-line, which might not fit neatly into a hash.
For instance, there can be duplicate keys (e.g. --install_path), in
addition to the problem you noticed.

Then you shouldn't be assigning makefile_to_build_macros() to a hash in the
first place (i.e. it should be @args), or else I'm missing the point.

Right, that's the point.


However, your fix is equivalent to mine, in that all of the others

No - your fix doesn't translate 'perl' to 'core' anymore.

 -Ken

Reply via email to