On Sep 17, 2008, at 11:48, David E. Wheeler wrote:

On Sep 16, 2008, at 15:42, Eric Wilhelm wrote:

While my big warning message might be loud and obnoxious, it:

1.  only appears if there is maybe a problem
2.  mentions Text::ParseWords and the version number
3.  doesn't actually do anything.

Well, no, it removes a test.

4.  can be removed in the next release.

Best,

David


FYI, I'm getting unexpected TODO passes on 5.10. This patch fixes it:

Index: t/ext.t
===================================================================
--- t/ext.t     (revision 11885)
+++ t/ext.t     (working copy)
@@ -5,6 +5,8 @@
 use MBTest;

 use Module::Build;
+use Carp;
+BEGIN {$SIG{__DIE__} = \&confess };

 my @unix_splits =
   (
@@ -77,7 +79,8 @@
 use Module::Build::Platform::Unix;
 foreach my $test (@unix_splits) {
   # Text::ParseWords bug:
-  local $TODO = $low_TPW_version && ((keys %$test)[0] =~ m{\\\n});
+  local $TODO = 'Text::ParseWords bug'
+      if $low_TPW_version && ((keys %$test)[0] =~ m{\\\n});

   do_split_tests('Module::Build::Platform::Unix', $test);
 }

Best,

David

Reply via email to