I find all three equally cringe'worthy (those two AND the original use version ...)
Adam K 2009/7/16 Gisle Aas <gi...@activestate.com>: > On Jul 15, 2009, at 23:36 , David Golden wrote: > >> >>> Seems like a good reason now to do this then. Perhaps it's better to >>> write: >>> >>> our $VERSION = version->declare("v1.2.3"); use version 1.00; >> >> <cringe> >> >> Yes, that "works" but I think it's horrible for readability. > > The suggestion was meant to improve readability and I still think it does. > It's now much easier to see that the purpose of this piece of code is to > set the value of $VERSION. We obviously disagree about what makes code > readable. > > Alternative: > > our $VERSION = do { use version 1.00; version->declare("v1.2.3") }; > > --Gisle > >