Hi there,
Does anyone have any objections to or comments on this small patch?
It adds a Mogstored::HTTPServer::None, which allows mogstored to be
run against an existing DAV backend which isn't managed by mogstored
(you need mogstored running to get usage info etc, but it's not always
convenient to have mogstored start/stop/configure the DAV server).
I'll take silence as assent and commit in a day or two if no-one says anything.
re: commit policy, is this change small enough to go in without
checking with the list?
jb
Index: server/mogstored
===================================================================
--- server/mogstored (revision 1114)
+++ server/mogstored (working copy)
@@ -42,6 +42,7 @@
use Mogstored::HTTPServer::Perlbal;
use Mogstored::HTTPServer::Lighttpd;
+use Mogstored::HTTPServer::None;
use Mogstored::HTTPServer::Apache;
use Mogstored::SideChannelListener;
use Mogstored::SideChannelClient;
@@ -84,8 +85,8 @@
);
usage() unless Getopt::Long::GetOptions(%config_opts);
-die "Unknown server type. Valid options: --server={perlbal,lighttpd,apache}"
- unless $server =~ /^perlbal|lighttpd|apache$/;
+die "Unknown server type. Valid options: --server={perlbal,lighttpd,apache,none}"
+ unless $server =~ /^perlbal|lighttpd|apache|none$/;
$opt_config = $default_config if ! $opt_config && -e $default_config;
load_config_file($opt_config => \%config_opts) if $opt_config;
Index: server/MANIFEST
===================================================================
--- server/MANIFEST (revision 1114)
+++ server/MANIFEST (working copy)
@@ -96,6 +96,7 @@
lib/Mogstored/HTTPServer/Apache.pm
lib/Mogstored/HTTPServer/Lighttpd.pm
lib/Mogstored/HTTPServer/Perlbal.pm
+lib/Mogstored/HTTPServer/None.pm
lib/Mogstored/SideChannelClient.pm
lib/Mogstored/SideChannelListener.pm
Makefile.PL
Index: server/lib/Mogstored/HTTPServer/None.pm
===================================================================
--- server/lib/Mogstored/HTTPServer/None.pm (revision 0)
+++ server/lib/Mogstored/HTTPServer/None.pm (revision 0)
@@ -0,0 +1,12 @@
+package Mogstored::HTTPServer::None;
+use strict;
+use base 'Mogstored::HTTPServer';
+
+# Allow the use of an existing backend DAV server not managed by mogstored
+
+sub start {
+ my $self = shift;
+ return 1;
+}
+
+1;
Index: server/CHANGES
===================================================================
--- server/CHANGES (revision 1114)
+++ server/CHANGES (working copy)
@@ -1,3 +1,6 @@
+ * Add Mogstored::HTTPServer::None to allow using mogstored
+ with unmanaged backend DAV servers.
+
* Add experimental cmd_edit_file. Client requires DAV MOVE and
partial PUT on the store to use it.
