sanados wrote: > dormando wrote: >>> idea: another state would be appreciated: initialize >>> when you first enter a device mark it initialize. >>> So it would cleanup old files / directories, does filesystem checks, ... >>> (just a thought) >>> >> >> First enter a device? If you're adding a brand-new device it should be >> freshly formatted? :) MogileFS is flexible about not caring how the >> device was initialized (or even if it has other data on it), so it's >> pretty nice to ignore that. >> >> Having lost files in the middle of the device that are unlinked >> everywhere else is bad tho. Fsck could probably have a scrubber mode >> you'd run once in a while, while these bugs are fixed. >> >> Or are you referring to something else? > I was refering to the situation that you bring an dead / down device > online again. > When the replication cleaned up every files there are quite some ghosts > on the once dead device.
Dead devices should never be brought back alive. Just remake the filesystem and create a new device id. ... and yeah, I'm seeing some turds on `drain`ed devices. From a hundred megs to a gig or two... I'm sure we can work in code to clean those up, but I don't really consider it a fix for files left on 'dead' devices, since those are supposed to go away. -Dormando
