On 08/10/2014 12:05 PM, James Wilmot wrote: > Moin Moin! > > I have hacked together a multiple file upload implementation > (using https://github.com/blueimp/jQuery-File-Upload)
Cool, I used the same stuff for another project (bepasty on github). > for my local usage on MoinMoin 1.9.X, but I would be interested in > polishing it and pushing it upstream. > > Questions: > > - 1.9.X seems to be feature stable at the moment, Yes, whether your change is acceptable for inclusion into 1.9 depends a lot on the impact it has on existing code / functionality. Also, some admins or distribution packagers might want to have it optional and off-by-default. > just to develop on top of MoinMoin 2.X? moin2 is preferable for new features. And IIRC we already have multi-file-upload there, I don't remember whether it was with that lib or some other one, though. Try throwing stuff onto the index page of moin2. > - the implementation I have is basically hacked into the > action/AttachFile.py but doesn't change any of the backend > functionality: it is all front end changes. Would it be best to put > the feature into an applet like the editor? I think I can give better advice if you just put the stuff on codereview.appspot.com and add me as a reviewer there. > Thanks for the excellent wiki and I hope to contribute back in > other ways in the future! (like the LDAP integration) You're welcome! And we would definitely like you trying moin2 and hacking it for usability. :) BTW, in next 1.9 release, there are some minor changes to deal with (==delete, move) "multiple attachments" already, see repo. BTW, if you use IRC, join us on #moin-dev on freenode. Cheers, Thomas ------------------------------------------------------------------------------ _______________________________________________ Moin-user mailing list Moin-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/moin-user
