> > let's see what happen in the next few days. Otherwise we can improve this > pr.
Seems doubtful he will respond. So we noted his PR needs tests and doc. Anything else you note to do, e.g. is the change ok or does that need adjusting? On Mon, Apr 6, 2020 at 9:59 PM Olivier Lamy <[email protected]> wrote: > > > On Tue, 7 Apr 2020 at 10:50, Jeff Jensen <[email protected]> wrote: > >> > looking now. >> Thank you! Much appreciated >> >> > as it's a new feature it would be good to have a test. >> Agreed. >> >> I also noticed no docs for the new feature; also needed. >> >> >> You probably saw I commented on the PR asking if he plans to finish. >> Hopefully so; I'll wait some days and if he doesn't reply, I'll assume the >> answer is no. >> > > let's see what happen in the next few days. Otherwise we can improve this > pr. > > >> >> >> On Mon, Apr 6, 2020 at 6:54 PM Olivier Lamy <[email protected]> >> wrote: >> >>> as it's a new feature it would be good to have a test. >>> >>> On Tue, 7 Apr 2020 at 09:21, Olivier Lamy <[email protected]> wrote: >>> >>>> looking now. >>>> >>>> On Tue, 7 Apr 2020 at 01:09, Jeff Jensen <[email protected]> wrote: >>>> >>>>> No response causes me to wonder if properties-maven-plugin a dead >>>>> plugin and is there an alternate plugin/approach available? >>>>> >>>>> >>>>> On Wed, Apr 1, 2020 at 8:47 AM Jeff Jensen <[email protected]> wrote: >>>>> >>>>>> Hi, I'm interested in a feature this PR >>>>>> <https://github.com/mojohaus/properties-maven-plugin/pull/42> [1] >>>>>> seems to fulfill for properties-maven-plugin. Is any committer >>>>>> interested >>>>>> in shepherding it through with me? Alternatively, I'll do it if granted >>>>>> privs and receive process guidance. >>>>>> >>>>>> [1] https://github.com/mojohaus/properties-maven-plugin/pull/42 >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "mojohaus-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/d/msgid/mojohaus-dev/ea7d6024-d499-4ff4-8673-a91419342618%40googlegroups.com >>>>>> <https://groups.google.com/d/msgid/mojohaus-dev/ea7d6024-d499-4ff4-8673-a91419342618%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "mojohaus-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/mojohaus-dev/CAKumxBwHWySp6%2BjqfS3Nhou1TFCZtxM0fw%3D-YG-9Tat4M1ZOoQ%40mail.gmail.com >>>>> <https://groups.google.com/d/msgid/mojohaus-dev/CAKumxBwHWySp6%2BjqfS3Nhou1TFCZtxM0fw%3D-YG-9Tat4M1ZOoQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> >>>> >>>> -- >>>> Olivier Lamy >>>> http://twitter.com/olamy | http://linkedin.com/in/olamy >>>> >>> >>> >>> -- >>> Olivier Lamy >>> http://twitter.com/olamy | http://linkedin.com/in/olamy >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "mojohaus-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqSh%2BS%2BkqpY8DC9sZKWq-Su8ve0jkcytHZZLnvY4b1Dmpw%40mail.gmail.com >>> <https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqSh%2BS%2BkqpY8DC9sZKWq-Su8ve0jkcytHZZLnvY4b1Dmpw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "mojohaus-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/mojohaus-dev/CAKumxBzEGXLx126PVRSHxpsvbrs39LCZFs0f1y57Mzn0shpALg%40mail.gmail.com >> <https://groups.google.com/d/msgid/mojohaus-dev/CAKumxBzEGXLx126PVRSHxpsvbrs39LCZFs0f1y57Mzn0shpALg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > > > -- > Olivier Lamy > http://twitter.com/olamy | http://linkedin.com/in/olamy > > -- > You received this message because you are subscribed to the Google Groups > "mojohaus-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqSTzAGJa5np-sMYb9nCXZuB4sik1exQhRLte_dLaX6kaQ%40mail.gmail.com > <https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqSTzAGJa5np-sMYb9nCXZuB4sik1exQhRLte_dLaX6kaQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "mojohaus-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAKumxBx3yo8sG8H6Q7DGyrEBrxSFfqY%3DCwUHwPNBsU0frvVkCA%40mail.gmail.com.
