Hello Anders, I just configured jacoco in extra-enforcer-rules in a branch: https://github.com/mojohaus/extra-enforcer-rules/commit/0d77f3159c3ab8d05396abbb98324a60a1c1aaeb Here coverage of unit tests and invoker tests are reported separately. As we are talking about using github actions, it should be easy to upload the results to codecov: https://github.com/codecov/codecov-action
Regards Mirko Am Montag, 20. Januar 2020 10:13:41 UTC+1 schrieb Anders Hammar: > > Haven't tried that. But not sure what purpose this report serves; do > anyone even look at it? We don't have code coverage reports for the apache > maven plugins via the plugins parent. > > Right now our mojos are, quite frankly, in a poor state. People are > complaining about lack of bug releases and some of them don't even support > Java 11. I, as well most others I guess, don't have much spare time to > spend on this so I'd like to fix this without starting a new big task. > Hence I'm in favor of removing the code coverage report. It can always be > added in the future when we have a better solution, or it can be added in > those mojos where we want it. > > /Anders > > On Mon, Jan 20, 2020 at 9:38 AM Mirko Friedenhagen <[email protected] > <javascript:>> wrote: > >> Hello Anders, >> >> including coverage achieved by invoker is often easily possible. Set >> `<invoker.mavenOpts>${argLine}</invoker.mavenOpts>`, that’s it. What do you >> think? >> >> Regards >> Mirko >> >> Am 20.01.2020 um 09:14 schrieb Anders Hammar <[email protected] >> <javascript:>>: >> >> Yes, I'm using JaCoCo also in my day job. But I'm rather in favor of just >> remove code coverage all together in the mojo-parent as most of our mojo >> testing is done via the invoker plugin. And that will not show upp in the >> code coverage which could then make people think that we have poor testing >> if they just read that report. >> >> If anyone is against removing speak up now or I'll go ahead and remove it. >> >> /Anders >> >> On Mon, Jan 20, 2020 at 6:56 AM Mirko Friedenhagen <[email protected] >> <javascript:>> wrote: >> >>> Hello Anders, hello everyone, >>> >>> I now for some years use jacoco instead of cobertura. Jacoco is well >>> maintained and quite fast and used by e.g. IntelliJ (and as far as I know >>> under the „brand“ Emma in Eclipse) and sonarqube as well by default. >>> >>> Best Regards >>> Mirko Friedenhagen >>> — >>> Sent from my mobile >>> >>> Am 19.01.20 um 21:33 schrieb Anders Hammar >>> >>> > Currently mojo-parent isn't buildable on Java 11 due to cobertura-m-p. >>> We >>> > need to fix this so that mojo-parent is in a releasable state. [1] >>> > >>> > As I see it we need to switch code coverage tool or possible even >>> remove it >>> > entirely in the mojo-parent. I'd appreciate input so that we could fix >>> this. >>> > >>> > [1] https://github.com/mojohaus/mojo-parent/issues/77 >>> > >>> > /Anders >>> > >>> > -- >>> > You received this message because you are subscribed to the Google >>> Groups "mojohaus-dev" group. >>> > To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] <javascript:>. >>> > To view this discussion on the web visit >>> https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1sk0Qn2-1BW-NsQJdsWY4JE5BM%2BU%3DqyWNVCG5FKhXNT-g%40mail.gmail.com >>> . >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "mojohaus-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] <javascript:>. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/mojohaus-dev/trinity-8982fea3-58bd-4d95-9c5b-5c0f0060a6c7-1579499759658%40msvc-mesg-gmx121 >>> . >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "mojohaus-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1tUuuRmj3N1AAtUeGHZ-HL-tmwBTL_cq541HmjgWuQ%3DWg%40mail.gmail.com >> >> <https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1tUuuRmj3N1AAtUeGHZ-HL-tmwBTL_cq541HmjgWuQ%3DWg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "mojohaus-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/mojohaus-dev/9904BA45-FB44-4E32-9BA2-AB4AAA3DC93D%40gmx.de >> >> <https://groups.google.com/d/msgid/mojohaus-dev/9904BA45-FB44-4E32-9BA2-AB4AAA3DC93D%40gmx.de?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "mojohaus-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/fd700059-0327-41db-b7f5-32a07143736bo%40googlegroups.com.
