This patch is interesting since it doesn't really seem to change the logic 
of the code, just the syntax (splitting out into another conditional). I'm 
probably just missing something, can you explain the patch?

Also, please diff -u or diff -c so readers of your patches can stay sane 
while reading them :)


thanks,
andrew

At 01:11 PM 4/4/02 -0800, Shchuka, Konstantin wrote:

>I've had to patch mon to make it process exclude_period configuration
>properly. Here is the diff:
>
>1461c1461
><               elsif ($var eq "exclude_period" && inPeriod (time, $args) 
>== -1)
>---
> >               elsif ($var eq "exclude_period" )
>1463,1464c1463,1467
><                   close (CFG);
><                   return "cf error: malformed exclude_period '$args' 
>(the specified time period is not valid as per Time::Period::inPeriod), 
>line $line_num";
>---
> >                       if (inPeriod (time, $args) == -1)
> >                       {
> >                               close (CFG);
> >                               return "cf error: malformed 
> exclude_period '$args' (the specified time period is not valid as per 
> Time::Period::inPeriod), line $line_num";
> >                       }
>
>
>--
>Konstantin 'Kastus' Shchuka
>Unix System Administrator
>ePocrates Inc.
>tel 650.232.4886
>fax 650.592.6995

Reply via email to