Bugs item #1267093, was opened at 2005-08-23 15:25
Message generated for change (Comment added) made by mlkersten
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1267093&group_id=56967

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: MonetDB4 CVS Head
>Status: Closed
>Resolution: Fixed
Priority: 2
Private: No
Submitted By: Sjoerd Mullender (sjoerd)
Assigned to: Nobody/Anonymous (nobody)
Summary: BUFSIZ considered harmful

Initial Comment:
In quite a few places in the code (certainly MonetDB,
possibly others) the symbol BUFSIZ is used to allocate
memory.  The problem with this is that BUFSIZ may be
too small on certain systems for the intended purposes.

For example: On Windows, BUFSIZ is defined as 512, and
this is too small for a decent-sized monet_mod_path
value (actually encountered when trying to run Mserver
from the build directory using RunMserver.bat).

We should go look at all occurences of BUFSIZ to see if
they are ok if the value is relatively small.

The problem mentioned could perhaps be solved if
mo_substitute were to allocate memory in which it
returns the substituted value instead of substituting
in-place.

----------------------------------------------------------------------

>Comment By: Martin Kersten (mlkersten)
Date: 2007-02-25 18:14

Message:
Logged In: YES 
user_id=490798
Originator: NO

Visited once more before closing:
Stable, modules, plain uses it in asii-io, str, pcre, upgrade. No serious
threads
Stable, monetdb and gdk all gone.

Stable, modules/mal, no harm
Stable, optimizer, one additional protection added

Stable, clients, seem protected

----------------------------------------------------------------------

Comment By: Fabian (mr-meltdown)
Date: 2006-06-06 20:56

Message:
Logged In: YES 
user_id=963970

Does this thing need some more search/replace work, or can
we close it?

----------------------------------------------------------------------

Comment By: Martin Kersten (mlkersten)
Date: 2006-01-20 11:29

Message:
Logged In: YES 
user_id=490798

gdk_desc.mx: not a real issue as long as atom type names are
less then 512

logger.mx: not serious and protected against overflow
only logger.new might cause a problem at some point.

pcre.mx: doesn't seem a big problem, unless pcre has very
long built in error messages. Most likely not.

----------------------------------------------------------------------

Comment By: Martin Kersten (mlkersten)
Date: 2006-01-20 11:11

Message:
Logged In: YES 
user_id=490798

gdk_desc.mx: not a real issue as long as atom type names are
less then 512

logger.mx: not serious and protected against overflow
only logger.new might cause a problem at some point.

pcre.mx: doesn't seem a big problem, unless pcre has very
long built in error messages. Most likely not.

----------------------------------------------------------------------

Comment By: Martin Kersten (mlkersten)
Date: 2006-01-15 15:53

Message:
Logged In: YES 
user_id=490798

An assessment without actions yet.

upgrade.mx : OK

str.mx: OK

pcrc.mx/prce_compile_wrap,  pcre_select, pcre_uselect,
pcre_replace: possible buffer overflow problems on
pcre_compile calls

logger.mx/logger_open: PROBLEM, BUFSIZ->PATHLENGTH
logger.mx/logger_new: idem
logger.mx/logger_exit: idem
logger.mx/logger_clean: idem

ascii_io.mx: OK

gdk_desc.mx: Dangerous, double check

gdk_posix.mx: OK

gdk_utils.mx:OK

----------------------------------------------------------------------

Comment By: Fabian (mr-meltdown)
Date: 2006-01-15 15:00

Message:
Logged In: YES 
user_id=963970

any news on this?

----------------------------------------------------------------------

Comment By: Stefan Manegold (stmane)
Date: 2005-12-19 15:39

Message:
Logged In: YES 
user_id=572415

BugDay_2005-12-19, stmane: NO TEST / CODING TECHNIQUE


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1267093&group_id=56967

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Monetdb-bugs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-bugs

Reply via email to