Bugs item #1754452, was opened at 2007-07-15 23:10
Message generated for change (Comment added) made by mr-meltdown
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1754452&group_id=56967
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: SQL/JDBC
Group: Clients CVS Head
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Aaron Evans (aaronevans)
Assigned to: Fabian (mr-meltdown)
Summary: NullPointerException in MonetConnection
Initial Comment:
While trying to perform many consecutive XQuery updates using the JDBC driver,
I eventually receive a NPE:
Exception in thread "SendThread" java.lang.NullPointerException
at
nl.cwi.monetdb.jdbc.MonetConnection$SendThread.run(MonetConnection.java:2115)
This constructor looks wrong to me:
public SendThread(BufferedMCLWriter conn) {
super("SendThread");
setDaemon(true);
this.out = out;
start();
}
It looks like SendThread should probably use the argument in the constructor.
----------------------------------------------------------------------
>Comment By: Fabian (mr-meltdown)
Date: 2007-07-17 12:57
Message:
Logged In: YES
user_id=963970
Originator: NO
TEST ADDED - meltdown
sql/src/jdbc/tests/Tests/Test_Clargequery
----------------------------------------------------------------------
Comment By: Fabian (mr-meltdown)
Date: 2007-07-17 10:53
Message:
Logged In: YES
user_id=963970
Originator: NO
yes, sorry. The batching test doesn't do this any more since it optimises
on the buffer size.
----------------------------------------------------------------------
Comment By: Stefan Manegold (stmane)
Date: 2007-07-17 10:42
Message:
Logged In: YES
user_id=572415
Originator: NO
Shouldn't we also add test for this one?
Aaron,
could you provides us with your experiment (data & update queries)?
Thanks in advance!
Stefan
----------------------------------------------------------------------
Comment By: Fabian (mr-meltdown)
Date: 2007-07-16 12:22
Message:
Logged In: YES
user_id=963970
Originator: NO
Fixed in CVS. Thanks!
----------------------------------------------------------------------
Comment By: Aaron Evans (aaronevans)
Date: 2007-07-16 11:43
Message:
Logged In: YES
user_id=1845614
Originator: YES
Yes, that patch eliminates the NPE.
----------------------------------------------------------------------
Comment By: Fabian (mr-meltdown)
Date: 2007-07-16 11:39
Message:
Logged In: YES
user_id=963970
Originator: NO
Indeed that looks like it is the case. I applied this patch:
diff -u -r1.16 MonetConnection.java
--- src/nl/cwi/monetdb/jdbc/MonetConnection.java 5 Jun 2007
10:31:41 -0000 1.16
+++ src/nl/cwi/monetdb/jdbc/MonetConnection.java 16 Jul 2007
09:25:09 -0000
@@ -2088,7 +2088,7 @@
*
* @param monet the socket to write to
*/
- public SendThread(BufferedMCLWriter conn) {
+ public SendThread(BufferedMCLWriter out) {
super("SendThread");
setDaemon(true);
this.out = out;
Can you check?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1754452&group_id=56967
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Monetdb-bugs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-bugs