Bugs item #1741459, was opened at 2007-06-22 14:36 Message generated for change (Comment added) made by stmane You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1741459&group_id=56967
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: PF/runtime Group: Pathfinder CVS Head >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Jan Rittinger (tsheyar) Assigned to: Peter Boncz (boncz) Summary: PF: ws_create inconsistently adds a collection node Initial Comment: In pathfinder.mx PROC ws_create a bogus COLLECTION node is added. This is however only done for a subset of PRE_* columns (PRE_CONT and NID_RID are ignored). If the first change to the working set container adds its nodes with append() the pre numbers are not aligned anymore. I propose to also add a dummy value for the ignored BATs. Then it shouldn't matter whether insert() or append() is used. As I have no idea how collections are represented I leave the solution to somebody else. ---------------------------------------------------------------------- >Comment By: Stefan Manegold (stmane) Date: 2007-08-12 19:11 Message: Logged In: YES user_id=572415 Originator: NO I consider the originally reported bug fixed by JanR's patch. No extra test required as the problem is covered by the existing algebra tests. The remaining algebra failures are covered by [ 1760459 ] PF/alg: tests fails since 2007/07/11 http://sourceforge.net/tracker/index.php?func=detail&aid=1760459&group_id=56967&atid=482468 Peter, Jan, please correct me, in case I'm wrong. ---------------------------------------------------------------------- Comment By: Stefan Manegold (stmane) Date: 2007-07-17 10:36 Message: Logged In: YES user_id=572415 Originator: NO JanR's suggested patch seems to fix most algebra tests without causing any (obvious) harm. However, some algebra tests still fail with "fatal error: attribute `item' referenced in projection not found" "halted in .../pathfinder/compiler/algebra/logical.c (PFla_project_), line 867" in the XQuery compiler. ---------------------------------------------------------------------- Comment By: Jan Rittinger (tsheyar) Date: 2007-07-06 18:17 Message: Logged In: YES user_id=993208 Originator: YES Peter, does the following patch do the correct thing? - Or is something else needed? =================================================================== RCS file: /cvsroot/monetdb/pathfinder/runtime/pathfinder.mx,v retrieving revision 1.370 diff -r1.370 pathfinder.mx 1366a1367,1368 > ws.fetch(PRE_CONT).fetch(WS).append(oid_nil); > ws.fetch(NID_RID).fetch(WS).append([EMAIL PROTECTED]); ---------------------------------------------------------------------- Comment By: Peter Boncz (boncz) Date: 2007-07-03 12:02 Message: Logged In: YES user_id=591107 Originator: NO the bogus collection is a super-root node for all temporarily constructed XML fragments thanks for noting -- will fix ---------------------------------------------------------------------- Comment By: Jan Rittinger (tsheyar) Date: 2007-06-29 18:11 Message: Logged In: YES user_id=993208 Originator: YES I think all failing algebra queries relate to this bug! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1741459&group_id=56967 ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-bugs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/monetdb-bugs
