Bugs item #1810292, was opened at 2007-10-09 17:41
Message generated for change (Comment added) made by mayrm
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1810292&group_id=56967
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Pathfinder 0.20
>Status: Closed
Resolution: Fixed
Priority: 9
Private: No
Submitted By: Stefan Manegold (stmane)
Assigned to: Manuel Mayr (mayrm)
Summary: PF: compilation of pfshred fails
Initial Comment:
When configure with --enable-strict --- which can unfortunately not be the
default in the to-be distributed code base and hence in the Stable branch(es),
as it might trigger "unnecessary compilation problems at user sites --- the
latest changes to pfshed fail to compile with:
========
gcc -DHAVE_CONFIG_H -I.
-I/export/scratch0/manegold/Monet/Testing/Stable/source/pathfinder/src/sqlhelpers/xmlshred
-I../../..
-I/export/scratch0/manegold/Monet/Testing/Stable/source/pathfinder/src/sqlhelpers/xmlshred
-I/export/scratch0/manegold/Monet/Testing/Stable/prefix.--enable-strict_--disable-optimize_--enable-debug_--enable-assert/include/MonetDB
-I/export/scratch0/manegold/Monet/Testing/Stable/prefix.--enable-strict_--disable-optimize_--enable-debug_--enable-assert/include/MonetDB/common
-I/export/scratch0/manegold/Monet/Testing/Stable/prefix.--enable-strict_--disable-optimize_--enable-debug_--enable-assert/include/MonetDB/gdk
-I/usr/include/libxml2 -I./include
-I/export/scratch0/manegold/Monet/Testing/Stable/source/pathfinder/src/sqlhelpers/xmlshred/./include
-I../../../compiler/include
-I/export/scratch0/manegold/Monet/Testing/Stable/source/pathfinder/src/sqlhelpers/xmlshred/../../../compiler/include
-I../../../compiler
-I/export/scratch0/manegold/Monet/Testing/Stable/source/pathfinder/src/sqlhelpers/xmlshred/../../../compiler
-Wall -Wextra -std=c99 -g -Werror-implicit-function-declaration -Werror
-Wpointer-arith -Wdeclaration-after-statement -Wundef -Wp,-D_FORTIFY_SOURCE=2
-Wno-declaration-after-statement -D_REENTRANT -c
/export/scratch0/manegold/Monet/Testing/Stable/source/pathfinder/src/sqlhelpers/xmlshred/encoding.c
cc1: warnings being treated as errors
/export/scratch0/manegold/Monet/Testing/Stable/source/pathfinder/src/sqlhelpers/xmlshred/encoding.c:
In function ‘flush_node’:
/export/scratch0/manegold/Monet/Testing/Stable/source/pathfinder/src/sqlhelpers/xmlshred/encoding.c:215:
warning: comparison between signed and unsigned
/export/scratch0/manegold/Monet/Testing/Stable/source/pathfinder/src/sqlhelpers/xmlshred/encoding.c:
In function ‘characters’:
/export/scratch0/manegold/Monet/Testing/Stable/source/pathfinder/src/sqlhelpers/xmlshred/encoding.c:438:
warning: comparison between signed and unsigned
make[7]: *** [encoding.o] Error 1
========
Please (try to) fix this a.s.a.p.
Moreover (for all of us, not only Manuel) explicitly configuring
--enable-strict (the default for nightly testing also for the Stable branch!)
is highly recommended to keep our code base clean and thus portable!
----------------------------------------------------------------------
>Comment By: Manuel Mayr (mayrm)
Date: 2007-10-10 08:46
Message:
Logged In: YES
user_id=1629542
Originator: NO
Hi Stefan,
thx for fixing.
Before I checked in those files I patched them into my HEAD directory
(assuming the --enable-strict option is set for default).
Well, I've turned on this option now, seeing those warnings myself.
Thx for your suggestions.
Manuel
----------------------------------------------------------------------
Comment By: Stefan Manegold (stmane)
Date: 2007-10-09 19:55
Message:
Logged In: YES
user_id=572415
Originator: YES
Since I ((too?) "generously") "allowed" Manuel'\''s last-minute checkin on
the Stable branch,
I also take the freedom to feel "responsible" for it and take care of
fixing the
"comparison between signed and unsigned"
warning (that is turned into an error when configured with
--enable-strict)
by casting the signed value to unsigned, provided the former ar
non-negative.
Manuel,
please double-check my fix and close this bug report in case it is OK.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1810292&group_id=56967
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Monetdb-bugs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-bugs
