Bugs item #1812882, was opened at 2007-10-13 16:54 Message generated for change (Comment added) made by stmane You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1812882&group_id=56967
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: PF/tests Group: Pathfinder 0.20 >Status: Closed >Resolution: Fixed Priority: 9 Private: No Submitted By: Stefan Manegold (stmane) >Assigned to: Sjoerd Mullender (sjoerd) Summary: PF: 24 tests fail after recent checkins Initial Comment: After checkins on Wed Oct 10 2007 and/or Thu Oct 11 2007 (due to compilation problems, there were no pathfinder-testing results on Thu Oct 11 2007), 24 pathfinder tests fail. This might be considered a show-stopper for the upcoming release! http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/benchmarks_XMark/upd.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/benchmarks_XMark_alg/upd.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/runtime/namespaces.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/runtime/serialization.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/runtime/serialization-mclient.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_BugTracker/nested_doc.SF-1446426.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_BugTracker/NULL_BAT_in_serializer.SF-1694814b.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_BugTracker/polymorphic_sequences.SF-1497419.mps.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_BugTracker/replace-corrupts.SF-1758902.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_BugTracker/replace-corrupts.SF-1758902.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_i18n/good-006.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_Update/setattr-1.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_Update/insert-1.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_Update/insert-2.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_Update/symm.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_Update/update.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_XQuery/attr_err.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_XQuery/element1.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_XQuery/element3.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_XQuery/element5.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_XQuery/element5.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_XQuery/element6.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_XQuery/fun6.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_XQuery/is2ns.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_XRpc/echoAll.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_XRpc/echoAll.err.00.html ---------------------------------------------------------------------- >Comment By: Stefan Manegold (stmane) Date: 2007-10-15 09:37 Message: Logged In: YES user_id=572415 Originator: YES Sjoerd's fix seems to work fine. Thanks! ---------------------------------------------------------------------- Comment By: Sjoerd Mullender (sjoerd) Date: 2007-10-14 11:16 Message: Logged In: YES user_id=43607 Originator: NO Checked in. Tomorrow we'll see if this is actually fixed. ---------------------------------------------------------------------- Comment By: Sjoerd Mullender (sjoerd) Date: 2007-10-14 10:42 Message: Logged In: YES user_id=43607 Originator: NO I'd like to check in a slightly different patch: in MonetDB.m4 I'll add a test AC_C_CHAR_UNSIGNED, and in scanner.l I'll change the #if into #ifndef __CHAR_UNSIGNED__. ---------------------------------------------------------------------- Comment By: Niels Nes (nielsnes) Date: 2007-10-14 08:33 Message: Logged In: YES user_id=43556 Originator: NO the borked ppc/gcc compiler seems to like this patch too. ---------------------------------------------------------------------- Comment By: Sjoerd Mullender (sjoerd) Date: 2007-10-14 00:14 Message: Logged In: YES user_id=43607 Originator: NO Yes, my patch does seem to work. The advantage is: no casts necessary. ---------------------------------------------------------------------- Comment By: Sjoerd Mullender (sjoerd) Date: 2007-10-13 23:10 Message: Logged In: YES user_id=43607 Originator: NO Does this more minimalist patch also work? || (c >= '\xf8' #if '\xff' == -1 && c <= '\xff' #endif ) instead of the current || (c >= '\xf8' /* c <= '\xff'*/ ) This of course assumes that the preprocessor and the compiler agree on the signedness of char. In any case, it looks like I will need to do a recompile. :-( ---------------------------------------------------------------------- Comment By: Stefan Manegold (stmane) Date: 2007-10-13 20:33 Message: Logged In: YES user_id=572415 Originator: YES Niels, Sjoerd, what about the attached patch that explicitly makes all char's (variables and constants) inside isncnamechar() signed and explicitly casts the arguments in the two calls of isncnamechar() to (const signed char)? Seems to work fine with gcc on Linux (FC6)... File Added: signed_char_patch ---------------------------------------------------------------------- Comment By: Niels Nes (nielsnes) Date: 2007-10-13 18:47 Message: Logged In: YES user_id=43556 Originator: NO Allthough \xfe .. \xff looks like the maximum of the the type (char) its not, its right in the middle (-8 till -1). So we need a different solution for the ppc compiler with 'unsigned' chars. So sjoerd shall we revert this in the to be released? ---------------------------------------------------------------------- Comment By: Niels Nes (nielsnes) Date: 2007-10-13 18:20 Message: Logged In: YES user_id=43556 Originator: NO reverting the range check in isncnamechar seems to fix the first problematic test. Now just need to find out why. ---------------------------------------------------------------------- Comment By: Niels Nes (nielsnes) Date: 2007-10-13 18:01 Message: Logged In: YES user_id=43556 Originator: NO reverting is not really a problem. But as you can see from my 2 line changes (one char -> signed char, one to range removed as higher values aren't possible for the type), they are not very likely to cause problems. ---------------------------------------------------------------------- Comment By: Stefan Manegold (stmane) Date: 2007-10-13 17:39 Message: Logged In: YES user_id=572415 Originator: YES The only checkins to pathfinder on 2007/10/10 & 2007/10/11 were by Sjoerd, Jennie & Niels. Those of Sjoerd & Jennie were most probably unrelated to this bug; while that of Niels might be related (see attached log & diffs for details). Niels, would it be possible to revert your changes completely to the version of Wed Oct 10 2007 early morning (tagged as Stable_DailyBuild-10)? File Added: log-diff ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1812882&group_id=56967 ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-bugs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/monetdb-bugs
