Bugs item #1870379, was opened at 2008-01-13 16:44 Message generated for change (Comment added) made by stmane You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1870379&group_id=56967
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: PF general Group: Clients CVS Head >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Stefan Manegold (stmane) Assigned to: Sjoerd Mullender (sjoerd) Summary: XQ: mclient/MAPI only echo first line of failing query Initial Comment: Since checkins on Fri Jan 11 2008, mclient/MAPI only echo the first line of failing queries, while the whole query (or at least as much as fit in some internal buffer) was echoed before; cf. http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.64.64.d-Fedora6/tests_BugDay_2005-11-09_0.9.3/xquery_crashtest.SF-1207048.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_BugDay_2005-12-19_0.9.3/zero-or-one_merged-union.SF-1221336.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_BugDay_2005-12-19_0.9.3/cast_as_anyNode.SF-1280519.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_BugDay_2005-12-19_0.9.3/type_error_in_cast.SF-1281176.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_BugTracker/call2builtin_function_crashes_XRPC_client.SF-1655857.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_BugTracker/type_check.SF-1705898.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_BugTracker/server-side_compilation_crash.SF-1607210.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-Darwin8.11.0/tests_BugTracker/crash_on_concatenated_query.SF-1730547.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_BugsViaSourgeforce/invisible_error_messages.SF-1409122.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_BugsViaSourgeforce/ID.1652527.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_XQuery/typing3.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_XQuery/matches01.err.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/pathfinder/.mTests103/GNU.32.32.d-CentOS4.4/tests_XQuery/matches02.err.00.html In case the new behaviour is "desired" / "not easily avoided", we should simply approve the new output. I suspect this to be related to one of the following checkins: =================================================================== 2008/01/11 - sjoerd: clients/src/mapiclient/MapiClient.mx,1.103 Do not use a calculated offset with fseek. It is not portable. Instead, we read one line at a time in XQuery mode to find lines that contain only "<>". =================================================================== =================================================================== 2008/01/11 - tsheyar: pathfinder/compiler/parser/scanner.l,1.55 -- Do not reset the error buffer inside the parser. (Messages generated by main.c get swallowed this way.) =================================================================== ---------------------------------------------------------------------- >Comment By: Stefan Manegold (stmane) Date: 2008-01-21 16:39 Message: Logged In: YES user_id=572415 Originator: YES Fixed by Sjoerd in CVS by approving the new output as desired and correct. ---------------------------------------------------------------------- Comment By: Sjoerd Mullender (sjoerd) Date: 2008-01-13 16:53 Message: Logged In: YES user_id=43607 Originator: NO It's definitely due to my checkin to MapiClient.mx. Echoing the failed query is done completely within mclient (MapiLib actually). The difference is due to the fact that XQuery queries are now read line by line instead of wholesale because we can't use fseek to seek back to the first occurrence of <> in the data. We can indeed approve the changed output, but we can also change MapiLib to remember more of the query. Let's do the approval. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1870379&group_id=56967 ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Monetdb-bugs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/monetdb-bugs
